Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1509903002: Add tracing to public PeerConnection methods. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add tracing to public PeerConnection methods. Adds tracing specifically to Close, for creating streams and also moves tracing for SetLocal/RemoteDescription from WebRtcSession. Also adding some tracing in ChannelManager to see what's taking time inside Close. BUG=webrtc:5167 R=tommi@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/1a9d615cbf93662519748aafc96d1ea23fa1a9e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M talk/app/webrtc/peerconnection.cc View 17 chunks +18 lines, -0 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M talk/session/media/channelmanager.cc View 7 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
PTAL, this moves tracing even higher and also catches some teardown tracing (Close()).
5 years ago (2015-12-08 13:45:27 UTC) #1
tommi
lgtm
5 years ago (2015-12-08 14:14:42 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1a9d615cbf93662519748aafc96d1ea23fa1a9e1 Cr-Commit-Position: refs/heads/master@{#10943}
5 years ago (2015-12-08 21:15:30 UTC) #5
pbos-webrtc
5 years ago (2015-12-08 21:15:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a9d615cbf93662519748aafc96d1ea23fa1a9e1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698