Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1508793002: Clang format of video_processing folder. (Closed)

Created:
5 years ago by mflodman
Modified:
5 years ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clang format of video_processing folder. BUG=webrtc:5259 Committed: https://crrev.com/99ab9447d1b48043adf6bfdf72cf820bbda3ee3f Cr-Commit-Position: refs/heads/master@{#10925}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Passes git cl lint #

Patch Set 3 : Casts + format again #

Patch Set 4 : One manual comment change. #

Patch Set 5 : pbos review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+498 lines, -508 lines) Patch
M webrtc/modules/video_processing/brightness_detection.cc View 2 chunks +24 lines, -22 lines 0 comments Download
M webrtc/modules/video_processing/content_analysis.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_processing/content_analysis.cc View 1 2 8 chunks +45 lines, -38 lines 0 comments Download
M webrtc/modules/video_processing/content_analysis_sse2.cc View 1 11 chunks +93 lines, -86 lines 0 comments Download
M webrtc/modules/video_processing/deflickering.h View 1 chunk +7 lines, -7 lines 0 comments Download
M webrtc/modules/video_processing/deflickering.cc View 1 2 3 4 11 chunks +40 lines, -36 lines 0 comments Download
M webrtc/modules/video_processing/frame_preprocessor.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/video_processing/frame_preprocessor.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/video_processing/include/video_processing.h View 1 2 3 4 2 chunks +1 line, -12 lines 0 comments Download
M webrtc/modules/video_processing/include/video_processing_defines.h View 1 chunk +11 lines, -11 lines 0 comments Download
M webrtc/modules/video_processing/spatial_resampler.h View 1 2 chunks +7 lines, -8 lines 0 comments Download
M webrtc/modules/video_processing/spatial_resampler.cc View 1 2 5 chunks +12 lines, -13 lines 0 comments Download
M webrtc/modules/video_processing/test/brightness_detection_test.cc View 1 chunk +84 lines, -83 lines 0 comments Download
M webrtc/modules/video_processing/test/content_metrics_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/video_processing/test/deflickering_test.cc View 1 chunk +57 lines, -58 lines 0 comments Download
M webrtc/modules/video_processing/test/video_processing_unittest.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/video_processing/test/video_processing_unittest.cc View 9 chunks +23 lines, -24 lines 0 comments Download
M webrtc/modules/video_processing/util/denoiser_filter.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/video_processing/util/denoiser_filter_c.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/util/denoiser_filter_neon.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M webrtc/modules/video_processing/util/denoiser_filter_sse2.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M webrtc/modules/video_processing/util/skin_detection.cc View 1 chunk +6 lines, -12 lines 0 comments Download
M webrtc/modules/video_processing/video_decimator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/video_decimator.cc View 5 chunks +23 lines, -21 lines 0 comments Download
M webrtc/modules/video_processing/video_denoiser.h View 1 chunk +5 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/video_denoiser.cc View 1 2 3 3 chunks +20 lines, -24 lines 0 comments Download
M webrtc/modules/video_processing/video_processing_impl.cc View 4 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mflodman
Peter, This is: 1. clang format video_processing/*, excluding Matlab files :) 2. Make sure git ...
5 years ago (2015-12-07 18:35:32 UTC) #2
pbos-webrtc
2 nits then lgtm https://codereview.webrtc.org/1508793002/diff/1/webrtc/modules/video_processing/deflickering.cc File webrtc/modules/video_processing/deflickering.cc (right): https://codereview.webrtc.org/1508793002/diff/1/webrtc/modules/video_processing/deflickering.cc#newcode329 webrtc/modules/video_processing/deflickering.cc:329: return (2); nit: remove ()s ...
5 years ago (2015-12-07 18:45:48 UTC) #3
mflodman
https://codereview.webrtc.org/1508793002/diff/1/webrtc/modules/video_processing/deflickering.cc File webrtc/modules/video_processing/deflickering.cc (right): https://codereview.webrtc.org/1508793002/diff/1/webrtc/modules/video_processing/deflickering.cc#newcode329 webrtc/modules/video_processing/deflickering.cc:329: return (2); On 2015/12/07 18:45:48, pbos-webrtc wrote: > nit: ...
5 years ago (2015-12-08 05:59:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508793002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508793002/80001
5 years ago (2015-12-08 05:59:23 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years ago (2015-12-08 06:54:54 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-08 06:55:07 UTC) #10
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/99ab9447d1b48043adf6bfdf72cf820bbda3ee3f
Cr-Commit-Position: refs/heads/master@{#10925}

Powered by Google App Engine
This is Rietveld 408576698