Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1508683004: Renaming JsepPeerConnectionP2PTestClient back to P2PTestConductor. (Closed)

Created:
5 years ago by Taylor Brandstetter
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Renaming JsepPeerConnectionP2PTestClient back to P2PTestConductor. Updating blacklists as well. Committed: https://crrev.com/7c73bdbd82956729ee2274318a451a481164f0c6 Cr-Commit-Position: refs/heads/master@{#10980}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -44 lines) Patch
M talk/app/webrtc/peerconnection_unittest.cc View 33 chunks +35 lines, -42 lines 0 comments Download
M tools/valgrind-webrtc/gtest_exclude/libjingle_peerconnection_unittest.gtest-drmemory_win32.txt View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind-webrtc/gtest_exclude/libjingle_peerconnection_unittest.gtest-memcheck.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Taylor Brandstetter
This is just a renaming (which I undid earlier, because it broke some bots: https://codereview.webrtc.org/1412553002/). ...
5 years ago (2015-12-07 20:43:14 UTC) #2
kjellander_webrtc
lgtm
5 years ago (2015-12-07 21:11:53 UTC) #3
pthatcher1
lgtm
5 years ago (2015-12-08 20:10:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508683004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508683004/1
5 years ago (2015-12-10 22:36:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 23:10:48 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-10 23:10:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c73bdbd82956729ee2274318a451a481164f0c6
Cr-Commit-Position: refs/heads/master@{#10980}

Powered by Google App Engine
This is Rietveld 408576698