Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: talk/app/webrtc/mediastreamobserver.h

Issue 1507973003: Restoring behavior where PeerConnection tracks changes to MediaStreams. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Check that iterator is valid before erasing. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2015 Google Inc. 3 * Copyright 2015 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
11 * this list of conditions and the following disclaimer in the documentation 11 * this list of conditions and the following disclaimer in the documentation
12 * and/or other materials provided with the distribution. 12 * and/or other materials provided with the distribution.
13 * 3. The name of the author may not be used to endorse or promote products 13 * 3. The name of the author may not be used to endorse or promote products
14 * derived from this software without specific prior written permission. 14 * derived from this software without specific prior written permission.
15 * 15 *
16 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED 16 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
17 * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF 17 * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
18 * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO 18 * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO
19 * EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 19 * EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
20 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 20 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
21 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; 21 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
22 * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, 22 * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
23 * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR 23 * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
24 * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF 24 * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
25 * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 25 * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
26 */ 26 */
27 27
28 // This file contains interfaces for RtpReceivers 28 #ifndef APP_WEBRTC_MEDIASTREAMOBSERVER_H_
29 // http://w3c.github.io/webrtc-pc/#rtcrtpreceiver-interface 29 #define APP_WEBRTC_MEDIASTREAMOBSERVER_H_
30 30
31 #ifndef TALK_APP_WEBRTC_RTPRECEIVERINTERFACE_H_
32 #define TALK_APP_WEBRTC_RTPRECEIVERINTERFACE_H_
33
34 #include <string>
35
36 #include "talk/app/webrtc/proxy.h"
37 #include "talk/app/webrtc/mediastreaminterface.h" 31 #include "talk/app/webrtc/mediastreaminterface.h"
38 #include "webrtc/base/refcount.h"
39 #include "webrtc/base/scoped_ref_ptr.h" 32 #include "webrtc/base/scoped_ref_ptr.h"
33 #include "webrtc/base/sigslot.h"
40 34
41 namespace webrtc { 35 namespace webrtc {
42 36
43 class RtpReceiverInterface : public rtc::RefCountInterface { 37 // Helper class which will listen for changes to a stream and emit the
38 // corresponding signals.
39 class MediaStreamObserver : public ObserverInterface {
44 public: 40 public:
45 virtual rtc::scoped_refptr<MediaStreamTrackInterface> track() const = 0; 41 explicit MediaStreamObserver(MediaStreamInterface* stream);
42 ~MediaStreamObserver();
46 43
47 // Not to be confused with "mid", this is a field we can temporarily use 44 const MediaStreamInterface* stream() const { return stream_; }
48 // to uniquely identify a receiver until we implement Unified Plan SDP.
49 virtual std::string id() const = 0;
50 45
51 virtual void Stop() = 0; 46 void OnChanged() override;
52 47
53 protected: 48 sigslot::signal2<AudioTrackInterface*, MediaStreamInterface*>
54 virtual ~RtpReceiverInterface() {} 49 SignalAudioTrackAdded;
50 sigslot::signal2<AudioTrackInterface*, MediaStreamInterface*>
51 SignalAudioTrackRemoved;
52 sigslot::signal2<VideoTrackInterface*, MediaStreamInterface*>
53 SignalVideoTrackAdded;
54 sigslot::signal2<VideoTrackInterface*, MediaStreamInterface*>
55 SignalVideoTrackRemoved;
56
57 private:
58 rtc::scoped_refptr<MediaStreamInterface> stream_;
59 AudioTrackVector cached_audio_tracks_;
60 VideoTrackVector cached_video_tracks_;
55 }; 61 };
56 62
57 // Define proxy for RtpReceiverInterface.
58 BEGIN_PROXY_MAP(RtpReceiver)
59 PROXY_CONSTMETHOD0(rtc::scoped_refptr<MediaStreamTrackInterface>, track)
60 PROXY_CONSTMETHOD0(std::string, id)
61 PROXY_METHOD0(void, Stop)
62 END_PROXY()
63
64 } // namespace webrtc 63 } // namespace webrtc
65 64
66 #endif // TALK_APP_WEBRTC_RTPRECEIVERINTERFACE_H_ 65 #endif // APP_WEBRTC_MEDIASTREAMOBSERVER_H_
OLDNEW
« no previous file with comments | « no previous file | talk/app/webrtc/mediastreamobserver.cc » ('j') | talk/app/webrtc/peerconnection.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698