webrtc/modules/audio_processing/high_pass_filter_impl.cc - Issue 1507683006: Make NoiseSuppression not a processing component (bit exact).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/high_pass_filter_impl.cc

Issue 1507683006: Make NoiseSuppression not a processing component (bit exact). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: missing explicit Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/high_pass_filter_impl.h ('k') | webrtc/modules/audio_processing/noise_suppression_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/high_pass_filter_impl.cc

diff --git a/webrtc/modules/audio_processing/high_pass_filter_impl.cc b/webrtc/modules/audio_processing/high_pass_filter_impl.cc

index 795dcbd21c7f9ba7bde203fc98e687059e2a5e25..0db794f94ef04cdb486fa973fbd133915ff878d3 100644

--- a/webrtc/modules/audio_processing/high_pass_filter_impl.cc

+++ b/webrtc/modules/audio_processing/high_pass_filter_impl.cc

@@ -89,6 +89,7 @@ HighPassFilterImpl::HighPassFilterImpl(rtc::CriticalSection* crit)

HighPassFilterImpl::~HighPassFilterImpl() {}

void HighPassFilterImpl::Initialize(int channels, int sample_rate_hz) {

+ RTC_DCHECK_LE(0, channels);

std::vector<rtc::scoped_ptr<BiquadFilter>> new_filters(channels);

for (int i = 0; i < channels; i++) {

new_filters[i].reset(new BiquadFilter(sample_rate_hz));

@@ -98,6 +99,7 @@ void HighPassFilterImpl::Initialize(int channels, int sample_rate_hz) {

}

void HighPassFilterImpl::ProcessCaptureAudio(AudioBuffer* audio) {

+ RTC_DCHECK(audio);

rtc::CritScope cs(crit_);

if (!enabled_) {

return;