Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1507343002: Fork: Disable quic in Android WebView. (Closed)

Created:
5 years ago by hush (inactive)
Modified:
5 years ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Fork: Disable quic in Android WebView. This is a fork in m48 due to a refactor made after m48 branch. BUG=566156 Review URL: https://codereview.chromium.org/1497113005 Cr-Commit-Position: refs/heads/master@{#363376} (cherry picked from commit 292ab9f948fd6ff4e6f2d4583724fb7acee19ef0)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/browser/net/aw_url_request_context_getter.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 6 (2 generated)
hush (inactive)
Hi Selim, PTAL. This refactor https://codereview.chromium.org/1448193002 changed the code a lot, so this is not ...
5 years ago (2015-12-08 18:57:42 UTC) #3
hush (inactive)
https://codereview.chromium.org/1507343002/diff/1/android_webview/browser/net/aw_url_request_context_getter.cc File android_webview/browser/net/aw_url_request_context_getter.cc (right): https://codereview.chromium.org/1507343002/diff/1/android_webview/browser/net/aw_url_request_context_getter.cc#newcode242 android_webview/browser/net/aw_url_request_context_getter.cc:242: false /* set_up_quic_server_info */)); actually this does not seem ...
5 years ago (2015-12-08 19:12:42 UTC) #4
hush (inactive)
On 2015/12/08 19:12:42, hush wrote: > https://codereview.chromium.org/1507343002/diff/1/android_webview/browser/net/aw_url_request_context_getter.cc > File android_webview/browser/net/aw_url_request_context_getter.cc (right): > > https://codereview.chromium.org/1507343002/diff/1/android_webview/browser/net/aw_url_request_context_getter.cc#newcode242 > ...
5 years ago (2015-12-08 19:32:40 UTC) #5
hush (inactive)
5 years ago (2015-12-08 20:07:40 UTC) #6
Okay. Looks like we didn't enable quic in m48 after all. Closing it.

Powered by Google App Engine
This is Rietveld 408576698