Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1507313005: [rtp_rtcp] SSRCDatabase class cleaned (including all lint errors) (Closed)

Created:
5 years ago by danilchap
Modified:
5 years ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtp_rtcp] SSRCDatabase class cleaned (including all lint errors) BUG=webrtc:5277 R=mflodman Committed: https://crrev.com/e005cf2c93555125e7446a790779f8984cf9fa67 Cr-Commit-Position: refs/heads/master@{#11023}

Patch Set 1 #

Patch Set 2 : removed incorrect ssrc validations: SSRC is not prohibited to be 0 or -1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -74 lines) Patch
M webrtc/modules/rtp_rtcp/source/ssrc_database.h View 3 chunks +8 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/ssrc_database.cc View 1 1 chunk +24 lines, -65 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
danilchap
while cleaning from lint errors, made a deeper clean since class is small but was ...
5 years ago (2015-12-10 12:23:28 UTC) #2
mflodman
LGTM
5 years ago (2015-12-14 13:28:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507313005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507313005/1
5 years ago (2015-12-14 14:43:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/7895)
5 years ago (2015-12-14 15:13:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507313005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507313005/20001
5 years ago (2015-12-14 19:13:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
5 years ago (2015-12-14 21:14:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507313005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507313005/20001
5 years ago (2015-12-15 08:27:56 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-15 09:59:51 UTC) #16
commit-bot: I haz the power
5 years ago (2015-12-15 09:59:58 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e005cf2c93555125e7446a790779f8984cf9fa67
Cr-Commit-Position: refs/heads/master@{#11023}

Powered by Google App Engine
This is Rietveld 408576698