Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issue 1507213002: Adding video_processing to presubmit lint check (Closed)

Created:
5 years ago by mflodman
Modified:
5 years ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding video_processing to presubmit lint check BUG=webrtc:5259 R=pbos@webrtc.org Committed: https://crrev.com/88eeac4aa7eaf22afc95bffbc8c2a2652b9222c8 Cr-Commit-Position: refs/heads/master@{#10928}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M PRESUBMIT.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mflodman
Peter, To close the VPM lint bug.
5 years ago (2015-12-08 08:07:56 UTC) #2
pbos-webrtc
lgtm, you'll need to rebase though please put "lint" in the CL description somewhere
5 years ago (2015-12-08 08:12:12 UTC) #3
mflodman
Committed patchset #2 (id:20001) manually as 88eeac4aa7eaf22afc95bffbc8c2a2652b9222c8 (presubmit successful).
5 years ago (2015-12-08 08:21:46 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-08 08:21:46 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88eeac4aa7eaf22afc95bffbc8c2a2652b9222c8
Cr-Commit-Position: refs/heads/master@{#10928}

Powered by Google App Engine
This is Rietveld 408576698