Add test which verifies that the RTP header extensions are set correctly for FEC packets.

Add test which verifies that the RTP header extensions are set correctly for FEC packets.

Also taking the opportunity to do a little bit of clean up.

BUG=webrtc:705
R=pbos@webrtc.org

Committed: https://crrev.com/4654d204e42d00dea43ce1e5b2200063e8272c8b
Cr-Commit-Position: refs/heads/master@{#10927}

[stefan-webrtc, 2015-12-07 15:31:16]

Description was changed from

==========
Add test which verifies that the RTP header extensions are set correctly for FEC
packets.

BUG=webrtc:705
==========

to

==========
Add test which verifies that the RTP header extensions are set correctly for FEC
packets.

Also taking the opportunity to do a little bit of clean up.

BUG=webrtc:705
==========

[stefan-webrtc, 2015-12-07 15:31:24]

stefan@webrtc.org changed reviewers:
+ pbos@webrtc.org

[stefan-webrtc, 2015-12-07 15:32:11]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-07 15:32:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1506863002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1506863002/1

[commit-bot: I haz the power, 2015-12-07 15:34:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 15:34:26]

Dry run: Try jobs failed on following builders:
  mac_compile_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)

[stefan-webrtc, 2015-12-07 15:36:38]

Fix build

[pbos-webrtc, 2015-12-07 15:44:00]

lgtm with these nits unknitted

https://codereview.webrtc.org/1506863002/diff/20001/webrtc/video/video_send_s...
File webrtc/video/video_send_stream_tests.cc (right):

https://codereview.webrtc.org/1506863002/diff/20001/webrtc/video/video_send_s...
webrtc/video/video_send_stream_tests.cc:357:
EXPECT_GE(header.extension.absoluteSendTime,
Might wrap.

https://codereview.webrtc.org/1506863002/diff/20001/webrtc/video/video_send_s...
webrtc/video/video_send_stream_tests.cc:360:
EXPECT_EQ(prev_header_.extension.transportSequenceNumber + 1,
Might wrap

[stefan-webrtc, 2015-12-07 15:53:38]

Handle wraps.

[stefan-webrtc, 2015-12-07 15:55:23]

Break out seq num diff

[stefan-webrtc, 2015-12-07 15:55:47]

The CQ bit was checked by stefan@webrtc.org

[stefan-webrtc, 2015-12-07 15:55:47]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1506863002/#ps60001 (title:
"Break out seq num diff")

[commit-bot: I haz the power, 2015-12-07 15:55:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1506863002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1506863002/60001

[commit-bot: I haz the power, 2015-12-07 15:57:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 15:57:59]

Try jobs failed on following builders:
  mac_x64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_x64_rel/builds/10995)

[stefan-webrtc, 2015-12-07 16:06:28]

Fix mac build

[stefan-webrtc, 2015-12-07 16:07:16]

The CQ bit was checked by stefan@webrtc.org

[stefan-webrtc, 2015-12-07 16:07:16]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1506863002/#ps80001 (title:
"Fix mac build")

[commit-bot: I haz the power, 2015-12-07 16:07:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1506863002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1506863002/80001

[commit-bot: I haz the power, 2015-12-07 16:13:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 16:13:54]

Try jobs failed on following builders:
  win_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/11389)

[stefan-webrtc, 2015-12-08 07:53:03]

The CQ bit was checked by stefan@webrtc.org

[stefan-webrtc, 2015-12-08 07:53:04]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1506863002/#ps100001 (title:
"Fix type.")

[commit-bot: I haz the power, 2015-12-08 07:53:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1506863002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1506863002/100001

[commit-bot: I haz the power, 2015-12-08 07:55:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 07:55:22]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2263)

[stefan-webrtc, 2015-12-08 08:11:02]

Description was changed from

==========
Add test which verifies that the RTP header extensions are set correctly for FEC
packets.

Also taking the opportunity to do a little bit of clean up.

BUG=webrtc:705
==========

to

==========
Add test which verifies that the RTP header extensions are set correctly for FEC
packets.

Also taking the opportunity to do a little bit of clean up.

BUG=webrtc:705
R=pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/4654d204e42d00dea43ce1e5b...
==========

[stefan-webrtc, 2015-12-08 08:11:04]

Committed patchset #6 (id:100001) manually as
4654d204e42d00dea43ce1e5b2200063e8272c8b (presubmit successful).

[commit-bot: I haz the power, 2015-12-08 08:11:04]

Description was changed from

==========
Add test which verifies that the RTP header extensions are set correctly for FEC
packets.

Also taking the opportunity to do a little bit of clean up.

BUG=webrtc:705
R=pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/4654d204e42d00dea43ce1e5b...
==========

to

==========
Add test which verifies that the RTP header extensions are set correctly for FEC
packets.

Also taking the opportunity to do a little bit of clean up.

BUG=webrtc:705
R=pbos@webrtc.org

Committed: https://crrev.com/4654d204e42d00dea43ce1e5b2200063e8272c8b
Cr-Commit-Position: refs/heads/master@{#10927}
==========

[commit-bot: I haz the power, 2015-12-08 08:11:05]

Patchset 6 (id:??) landed as
https://crrev.com/4654d204e42d00dea43ce1e5b2200063e8272c8b
Cr-Commit-Position: refs/heads/master@{#10927}