Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1506823002: [rtp_rtcp] fixed namespaces lint warnings (Closed)

Created:
5 years ago by danilchap
Modified:
5 years ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

in rtp_rtcp module: fixed build/namespaces lint errors fixed readability/namespace lint errors BUG=webrtc:5277 R=mflodman,stefan@webrtc.org Committed: https://crrev.com/6a6f0893dd1e653410ba4b22e7f33947d15aeb65 Cr-Commit-Position: refs/heads/master@{#10978}

Patch Set 1 #

Patch Set 2 : readability/namespace errors fixed #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -51 lines) Patch
M webrtc/modules/rtp_rtcp/source/byte_io.h View 1 chunk +6 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/fec_private_tables_bursty.h View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/fec_private_tables_random.h View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/fec_test_helper.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/forward_error_correction_internal.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_utility.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_utility.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extension.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/vp8_partition_aggregator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/vp8_partition_aggregator.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/vp8_partition_aggregator_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/test/BWEStandAlone/MatlabPlot.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/test/BWEStandAlone/TestSenderReceiver.h View 2 chunks +1 line, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc View 2 chunks +5 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/test/testFec/average_residual_loss_xor_codes.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testFec/test_packet_masks_metrics.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
danilchap
Stefan, I included you because I had to touch test/BWE.../MatlabPlot.cc file. I guess one need ...
5 years ago (2015-12-07 13:45:10 UTC) #1
mflodman
Minor comments, then LGTM. https://codereview.webrtc.org/1506823002/diff/20001/webrtc/modules/rtp_rtcp/source/forward_error_correction_internal.cc File webrtc/modules/rtp_rtcp/source/forward_error_correction_internal.cc (right): https://codereview.webrtc.org/1506823002/diff/20001/webrtc/modules/rtp_rtcp/source/forward_error_correction_internal.cc#newcode21 webrtc/modules/rtp_rtcp/source/forward_error_correction_internal.cc:21: using webrtc::fec_private_tables::kPacketMaskBurstyTbl; Alphabetic order. https://codereview.webrtc.org/1506823002/diff/20001/webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc ...
5 years ago (2015-12-09 09:27:03 UTC) #4
danilchap
https://codereview.webrtc.org/1506823002/diff/20001/webrtc/modules/rtp_rtcp/source/forward_error_correction_internal.cc File webrtc/modules/rtp_rtcp/source/forward_error_correction_internal.cc (right): https://codereview.webrtc.org/1506823002/diff/20001/webrtc/modules/rtp_rtcp/source/forward_error_correction_internal.cc#newcode21 webrtc/modules/rtp_rtcp/source/forward_error_correction_internal.cc:21: using webrtc::fec_private_tables::kPacketMaskBurstyTbl; On 2015/12/09 09:27:03, mflodman wrote: > Alphabetic ...
5 years ago (2015-12-09 09:53:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506823002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506823002/60001
5 years ago (2015-12-10 18:25:23 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-10 20:39:15 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-10 20:39:24 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/6a6f0893dd1e653410ba4b22e7f33947d15aeb65
Cr-Commit-Position: refs/heads/master@{#10978}

Powered by Google App Engine
This is Rietveld 408576698