Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1506203006:
Remove unnecessary test code on Windows. (Closed)
|
Created:
5 years ago by tommi Modified:
5 years ago Reviewers:
niklas.enbom CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove unnecessary test code on Windows.
BUG=chromium:568266, chromium:567264
R=niklas.enbom@webrtc.org
Committed: https://crrev.com/a6e4328680e263a0b5f423828ae653816f2fac70
Cr-Commit-Position: refs/heads/master@{#10961}
Patch Set 1 #
Messages
Total messages: 15 (8 generated)
tommi@webrtc.org changed reviewers: + niklas.enbom@webrtc.org
The CQ bit was checked by tommi@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506203006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506203006/1
Description was changed from ========== Remove unnecessary test code on Windows. BUG=568266,567264 ========== to ========== Remove unnecessary test code on Windows. BUG=chromium:568266,chromium:567264 ==========
I actually thought this code was deleted before we made this open source... lgtm On 2015/12/09 22:13:59, commit-bot: I haz the power wrote: > Dry run: CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1506203006/1 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/1506203006/1
Description was changed from ========== Remove unnecessary test code on Windows. BUG=chromium:568266,chromium:567264 ========== to ========== Remove unnecessary test code on Windows. BUG=chromium:568266,chromium:567264 R=niklas.enbom@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/a6e4328680e263a0b5f423828... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as a6e4328680e263a0b5f423828ae653816f2fac70 (presubmit successful).
Message was sent while issue was closed.
Description was changed from ========== Remove unnecessary test code on Windows. BUG=chromium:568266,chromium:567264 R=niklas.enbom@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/a6e4328680e263a0b5f423828... ========== to ========== Remove unnecessary test code on Windows. BUG=chromium:568266,chromium:567264 R=niklas.enbom@webrtc.org Committed: https://crrev.com/a6e4328680e263a0b5f423828ae653816f2fac70 Cr-Commit-Position: refs/heads/master@{#10961} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a6e4328680e263a0b5f423828ae653816f2fac70 Cr-Commit-Position: refs/heads/master@{#10961}
Message was sent while issue was closed.
Amazing that it lasted for so long ;-)
Message was sent while issue was closed.
solenberg@webrtc.org changed reviewers: + solenberg@webrtc.org
Message was sent while issue was closed.
awesome :)
Message was sent while issue was closed.
Description was changed from ========== Remove unnecessary test code on Windows. BUG=chromium:568266,chromium:567264 R=niklas.enbom@webrtc.org Committed: https://crrev.com/a6e4328680e263a0b5f423828ae653816f2fac70 Cr-Commit-Position: refs/heads/master@{#10961} ========== to ========== Remove unnecessary test code on Windows. BUG=chromium:568266,chromium:567264 R=niklas.enbom@webrtc.org Committed: https://crrev.com/a6e4328680e263a0b5f423828ae653816f2fac70 Cr-Commit-Position: refs/heads/master@{#10961} ==========
Message was sent while issue was closed.
solenberg@webrtc.org changed reviewers: - solenberg@webrtc.org |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
