Prevent RTCP SR to be sent with bogus timestamp.

webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 328 matching lines @@
   EXPECT_EQ(0, sender_.impl_->SendRTCP(kRtcpReport));
 
   // Verify RTT.
   EXPECT_EQ(0, receiver_.rtt_stats_.LastProcessedRtt());
   EXPECT_EQ(0, receiver_.impl_->rtt_ms());
   receiver_.impl_->Process();
   EXPECT_EQ(2 * kOneWayNetworkDelayMs, receiver_.rtt_stats_.LastProcessedRtt());
   EXPECT_EQ(2 * kOneWayNetworkDelayMs, receiver_.impl_->rtt_ms());
 }
 
+TEST_F(RtpRtcpImplTest, NoSrBeforeMedia) {

[stefan-webrtc, 2015/12/10 08:05:40]

Do you think there's anything else to test, such as that RR still will be sent
even if we haven't sent rtp packets? Maybe we already have a test that verifies
this?

[mflodman, 2015/12/10 08:59:53]

I added a test verifying the receive module still is sending RR.

+  sender_.impl_->Process();
+  EXPECT_EQ(-1, sender_.RtcpSent().first_packet_time_ms);
+  clock_.AdvanceTimeMilliseconds(2000);
+  int64_t current_time = clock_.TimeInMilliseconds();
+  sender_.impl_->Process();
+  EXPECT_EQ(-1, sender_.RtcpSent().first_packet_time_ms);
+  SendFrame(&sender_, kBaseLayerTid);
+  // sender_.impl_->Process();

[mflodman, 2015/12/10 06:08:20]

Depending on the answer to the other comment, I'll remove this or add an extra
check that no SR is sent with SendFrame().

+  EXPECT_EQ(sender_.RtcpSent().first_packet_time_ms, current_time);
+}
+
 TEST_F(RtpRtcpImplTest, RtcpPacketTypeCounter_Nack) {
   EXPECT_EQ(-1, receiver_.RtcpSent().first_packet_time_ms);
   EXPECT_EQ(-1, sender_.RtcpReceived().first_packet_time_ms);
   EXPECT_EQ(0U, sender_.RtcpReceived().nack_packets);
   EXPECT_EQ(0U, receiver_.RtcpSent().nack_packets);
 
   // Receive module sends a NACK.
   const uint16_t kNackLength = 1;
   uint16_t nack_list[kNackLength] = {123};
   EXPECT_EQ(0, receiver_.impl_->SendNACK(nack_list, kNackLength));
@@ skipping 156 matching lines @@
   EXPECT_EQ(8U, receiver_.RtcpSent().nack_requests);
   EXPECT_EQ(6U, receiver_.RtcpSent().unique_nack_requests);
   EXPECT_THAT(receiver_.LastNackListSent(), ElementsAre(11, 18, 20, 21));
 
   // Send module receives the request.
   EXPECT_EQ(2U, sender_.RtcpReceived().nack_packets);
   EXPECT_EQ(8U, sender_.RtcpReceived().nack_requests);
   EXPECT_EQ(6U, sender_.RtcpReceived().unique_nack_requests);
   EXPECT_EQ(75, sender_.RtcpReceived().UniqueNackRequestsInPercent());
 }
-
 }  // namespace webrtc