Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1505993003: [rtp_rtcp] lint build/include errors fixed (Closed)

Created:
5 years ago by danilchap
Modified:
5 years ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

lint build/include errors fixed in rtp_rtcp module BUG=webrtc:5277 R=mflodman Committed: https://crrev.com/b8b6fbb7a5d2f5a14f7f6f81c253747aa28e4c7f Cr-Commit-Position: refs/heads/master@{#10971}

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -20 lines) Patch
M webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/h264_bitstream_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_utility.cc View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_utility.h View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_utility.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/tmmbr_help.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/test/BWEStandAlone/MatlabPlot.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
danilchap
5 years ago (2015-12-08 12:44:20 UTC) #2
mflodman
One comment, then LGTM. https://codereview.webrtc.org/1505993003/diff/1/webrtc/modules/rtp_rtcp/source/rtp_sender.h File webrtc/modules/rtp_rtcp/source/rtp_sender.h (right): https://codereview.webrtc.org/1505993003/diff/1/webrtc/modules/rtp_rtcp/source/rtp_sender.h#newcode18 webrtc/modules/rtp_rtcp/source/rtp_sender.h:18: #include <set> I don't see ...
5 years ago (2015-12-10 07:50:45 UTC) #3
danilchap
https://codereview.webrtc.org/1505993003/diff/1/webrtc/modules/rtp_rtcp/source/rtp_sender.h File webrtc/modules/rtp_rtcp/source/rtp_sender.h (right): https://codereview.webrtc.org/1505993003/diff/1/webrtc/modules/rtp_rtcp/source/rtp_sender.h#newcode18 webrtc/modules/rtp_rtcp/source/rtp_sender.h:18: #include <set> On 2015/12/10 07:50:45, mflodman wrote: > I ...
5 years ago (2015-12-10 10:18:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505993003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505993003/40001
5 years ago (2015-12-10 11:39:30 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-10 13:05:31 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-10 13:05:42 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b8b6fbb7a5d2f5a14f7f6f81c253747aa28e4c7f
Cr-Commit-Position: refs/heads/master@{#10971}

Powered by Google App Engine
This is Rietveld 408576698