Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Side by Side Diff: talk/app/webrtc/mediastreaminterface.h

Issue 1505253004: Support for remote audio into tracks (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Address comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | talk/app/webrtc/mediastreamprovider.h » ('j') | talk/app/webrtc/webrtcsession.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2012 Google Inc. 3 * Copyright 2012 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 public: 160 public:
161 virtual void OnSetVolume(double volume) = 0; 161 virtual void OnSetVolume(double volume) = 0;
162 162
163 protected: 163 protected:
164 virtual ~AudioObserver() {} 164 virtual ~AudioObserver() {}
165 }; 165 };
166 166
167 // TODO(xians): Makes all the interface pure virtual after Chrome has their 167 // TODO(xians): Makes all the interface pure virtual after Chrome has their
168 // implementations. 168 // implementations.
169 // Sets the volume to the source. |volume| is in the range of [0, 10]. 169 // Sets the volume to the source. |volume| is in the range of [0, 10].
170 // TODO(tommi): This method should be on the track and ideally volume should
171 // be applied in the track in a way that does not affect clones of the track.
170 virtual void SetVolume(double volume) {} 172 virtual void SetVolume(double volume) {}
171 173
172 // Registers/unregisters observer to the audio source. 174 // Registers/unregisters observer to the audio source.
173 virtual void RegisterAudioObserver(AudioObserver* observer) {} 175 virtual void RegisterAudioObserver(AudioObserver* observer) {}
174 virtual void UnregisterAudioObserver(AudioObserver* observer) {} 176 virtual void UnregisterAudioObserver(AudioObserver* observer) {}
175 }; 177 };
176 178
177 // Interface for receiving audio data from a AudioTrack. 179 // Interface for receiving audio data from a AudioTrack.
178 class AudioTrackSinkInterface { 180 class AudioTrackSinkInterface {
179 public: 181 public:
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 virtual bool RemoveTrack(AudioTrackInterface* track) = 0; 269 virtual bool RemoveTrack(AudioTrackInterface* track) = 0;
268 virtual bool RemoveTrack(VideoTrackInterface* track) = 0; 270 virtual bool RemoveTrack(VideoTrackInterface* track) = 0;
269 271
270 protected: 272 protected:
271 virtual ~MediaStreamInterface() {} 273 virtual ~MediaStreamInterface() {}
272 }; 274 };
273 275
274 } // namespace webrtc 276 } // namespace webrtc
275 277
276 #endif // TALK_APP_WEBRTC_MEDIASTREAMINTERFACE_H_ 278 #endif // TALK_APP_WEBRTC_MEDIASTREAMINTERFACE_H_
OLDNEW
« no previous file with comments | « no previous file | talk/app/webrtc/mediastreamprovider.h » ('j') | talk/app/webrtc/webrtcsession.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698