Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1505023003: Add tracing to upper-level WebRTC calls. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add tracing to upper-level WebRTC calls. Adds tracing to WebRtcSession and corresponding BaseChannel calls to see where time is spent better. BUG=webrtc:5167 R=tommi@webrtc.org Committed: https://crrev.com/9f45a45a628100d973111b3aac66dede57454b6a Cr-Commit-Position: refs/heads/master@{#10934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M talk/app/webrtc/webrtcsession.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M talk/session/media/channel.cc View 8 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pbos-webrtc
PTAL, I'm not responsible for the stripes, but I want SetLocalDescription etc. to be traced ...
5 years ago (2015-12-08 10:57:55 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505023003/1
5 years ago (2015-12-08 10:58:04 UTC) #3
tommi
lgtm
5 years ago (2015-12-08 10:59:29 UTC) #4
pbos-webrtc
Committed patchset #1 (id:1) manually as 9f45a45a628100d973111b3aac66dede57454b6a (presubmit successful).
5 years ago (2015-12-08 12:26:16 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-08 12:26:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f45a45a628100d973111b3aac66dede57454b6a
Cr-Commit-Position: refs/heads/master@{#10934}

Powered by Google App Engine
This is Rietveld 408576698