webrtc/examples/peerconnection/server/peer_channel.cc - Issue 1504283004: Enable cpplint for webrtc/examples and fix all uncovered cpplint errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/examples/peerconnection/server/peer_channel.cc

Issue 1504283004: Enable cpplint for webrtc/examples and fix all uncovered cpplint errors. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/examples/peerconnection/client/linux/main_wnd.cc ('K') | « webrtc/examples/peerconnection/server/peer_channel.h ('k') | webrtc/examples/peerconnection/server/utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/examples/peerconnection/server/peer_channel.cc

diff --git a/webrtc/examples/peerconnection/server/peer_channel.cc b/webrtc/examples/peerconnection/server/peer_channel.cc

index 150e5dec97b1a434b5c77508528c637a258b82b7..5e173cd4602a64a91c7460acf14562a5a8624c3f 100644

--- a/webrtc/examples/peerconnection/server/peer_channel.cc

+++ b/webrtc/examples/peerconnection/server/peer_channel.cc

@@ -19,6 +19,7 @@

#include "webrtc/examples/peerconnection/server/data_socket.h"

#include "webrtc/examples/peerconnection/server/utils.h"

#include "webrtc/base/stringutils.h"

+#include "webrtc/base/urlencode.h"

using rtc::sprintfn;

@@ -59,7 +60,7 @@ ChannelMember::ChannelMember(DataSocket* socket)

assert(socket);

assert(socket->method() == DataSocket::GET);

assert(socket->PathEquals("/sign_in"));

- name_ = socket->request_arguments(); // TODO: urldecode

+ name_ = rtc::UrlDecodeString(socket->request_arguments());

if (name_.empty())

name_ = "peer_" + int2str(id_);

else if (name_.length() > kMaxNameLength)