webrtc/examples/peerconnection/client/defaults.cc - Issue 1504283004: Enable cpplint for webrtc/examples and fix all uncovered cpplint errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/examples/peerconnection/client/defaults.cc

Issue 1504283004: Enable cpplint for webrtc/examples and fix all uncovered cpplint errors. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/examples/peerconnection/client/defaults.h ('k') | webrtc/examples/peerconnection/client/flagdefs.h » ('j') | webrtc/examples/peerconnection/client/linux/main.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/examples/peerconnection/client/defaults.cc

diff --git a/webrtc/examples/peerconnection/client/defaults.cc b/webrtc/examples/peerconnection/client/defaults.cc

index f70aa72e3da5b4aa5814078d5a7e05631356a547..a2501c718f62b0a4642a9e3c594a03db2a46d12d 100644

--- a/webrtc/examples/peerconnection/client/defaults.cc

+++ b/webrtc/examples/peerconnection/client/defaults.cc

@@ -50,10 +50,12 @@ std::string GetDefaultServerName() {

std::string GetPeerName() {

char computer_name[256];

- if (gethostname(computer_name, arraysize(computer_name)) != 0)

- strcpy(computer_name, "host");

std::string ret(GetEnvVarOrDefault("USERNAME", "user"));

ret += '@';

- ret += computer_name;

+ if (gethostname(computer_name, arraysize(computer_name)) == 0) {

+ ret += computer_name;

+ } else {

+ ret += "host";

+ }

return ret;

}