Enable cpplint for webrtc/examples and fix all uncovered cpplint errors.

Enable cpplint for webrtc/examples and fix all uncovered cpplint errors.

BUG=webrtc:5273
TESTED=Fixed issues reported by:
find webrtc/examples/ -type f -name *.cc -o -name *.h | grep -v objc | xargs cpplint.py
followed by 'git cl presubmit'.

NOTRY=True

Committed: https://crrev.com/70625e5bf3c91c57bf704d380bcc9df86575f08a
Cr-Commit-Position: refs/heads/master@{#10960}

[joachim, 2015-12-08 23:23:43]

jbauch@webrtc.org changed reviewers:
+ glaznev@webrtc.org, kjellander@webrtc.org

[joachim, 2015-12-08 23:23:44]

@kjellander: there are three "Missing username in TODO" cpplint errors
remaining, any idea who to enter there?

@glaznev: ptal webrtc/examples

https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
File webrtc/examples/peerconnection/client/linux/main.cc (left):

https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
webrtc/examples/peerconnection/client/linux/main.cc:99: // TODO: Run the Gtk
main loop to tear down the connection.
This fails with "Missing username in TODO", who should I enter?

https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
File webrtc/examples/peerconnection/client/linux/main.cc (right):

https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
webrtc/examples/peerconnection/client/linux/main.cc:33: // TODO: We really
should move either the socket server or UI to a
This fails with "Missing username in TODO", who should I enter?

https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
File webrtc/examples/peerconnection/client/linux/main_wnd.cc (right):

https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
webrtc/examples/peerconnection/client/linux/main_wnd.cc:493: // TODO: Convert
directly to RGBA
This fails with "Missing username in TODO", who should I enter?

[kjellander_webrtc, 2015-12-09 14:41:47]

lgtm

I don't have anything better than entering the person that shows up in git blame
for the line. We could clean up those TODOs separately in the future.

https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
File webrtc/examples/peerconnection/client/linux/main.cc (left):

https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
webrtc/examples/peerconnection/client/linux/main.cc:99: // TODO: Run the Gtk
main loop to tear down the connection.
On 2015/12/08 23:23:44, joachim wrote:
> This fails with "Missing username in TODO", who should I enter?

henrike in this case too, i.e. TODO(henrike):

https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
File webrtc/examples/peerconnection/client/linux/main.cc (right):

https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
webrtc/examples/peerconnection/client/linux/main.cc:33: // TODO: We really
should move either the socket server or UI to a
On 2015/12/08 23:23:44, joachim wrote:
> This fails with "Missing username in TODO", who should I enter?

I suggest just pick the one that shows up in git blame.
I this case it's henrike that has left the team, but hey it's better than
nothing since we'd like to keep the PRESUBMIT check.

https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
File webrtc/examples/peerconnection/client/linux/main_wnd.cc (right):

https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
webrtc/examples/peerconnection/client/linux/main_wnd.cc:493: // TODO: Convert
directly to RGBA
On 2015/12/08 23:23:44, joachim wrote:
> This fails with "Missing username in TODO", who should I enter?

henrike in this case too.

[AlexG, 2015-12-09 17:49:26]

lgtm

[joachim, 2015-12-09 20:06:05]

The CQ bit was checked by jbauch@webrtc.org

[joachim, 2015-12-09 20:06:05]

The patchset sent to the CQ was uploaded after l-g-t-m from glaznev@webrtc.org,
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1504283004/#ps20001 (title:
"Add "henrike" to TODO markers")

[commit-bot: I haz the power, 2015-12-09 20:06:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1504283004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1504283004/20001

[joachim, 2015-12-09 20:06:42]

On 2015/12/09 14:41:47, kjellander (webrtc) wrote:
> lgtm
> 
> I don't have anything better than entering the person that shows up in git
blame
> for the line. We could clean up those TODOs separately in the future.
> 
>
https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
> File webrtc/examples/peerconnection/client/linux/main.cc (left):
> 
>
https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
> webrtc/examples/peerconnection/client/linux/main.cc:99: // TODO: Run the Gtk
> main loop to tear down the connection.
> On 2015/12/08 23:23:44, joachim wrote:
> > This fails with "Missing username in TODO", who should I enter?
> 
> henrike in this case too, i.e. TODO(henrike):
> 
>
https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
> File webrtc/examples/peerconnection/client/linux/main.cc (right):
> 
>
https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
> webrtc/examples/peerconnection/client/linux/main.cc:33: // TODO: We really
> should move either the socket server or UI to a
> On 2015/12/08 23:23:44, joachim wrote:
> > This fails with "Missing username in TODO", who should I enter?
> 
> I suggest just pick the one that shows up in git blame.
> I this case it's henrike that has left the team, but hey it's better than
> nothing since we'd like to keep the PRESUBMIT check.
> 
>
https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
> File webrtc/examples/peerconnection/client/linux/main_wnd.cc (right):
> 
>
https://codereview.webrtc.org/1504283004/diff/1/webrtc/examples/peerconnectio...
> webrtc/examples/peerconnection/client/linux/main_wnd.cc:493: // TODO: Convert
> directly to RGBA
> On 2015/12/08 23:23:44, joachim wrote:
> > This fails with "Missing username in TODO", who should I enter?
> 
> henrike in this case too.

Thanks, updated the TODO lines.

[commit-bot: I haz the power, 2015-12-09 22:06:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 22:06:32]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[kjellander_webrtc, 2015-12-09 22:14:21]

Description was changed from

==========
Enable cpplint for webrtc/examples and fix all uncovered cpplint errors.

BUG=webrtc:5273
TESTED=Fixed issues reported by:
find webrtc/examples/ -type f -name *.cc -o -name *.h | grep -v objc | xargs
cpplint.py
followed by 'git cl presubmit'.
==========

to

==========
Enable cpplint for webrtc/examples and fix all uncovered cpplint errors.

BUG=webrtc:5273
TESTED=Fixed issues reported by:
find webrtc/examples/ -type f -name *.cc -o -name *.h | grep -v objc | xargs
cpplint.py
followed by 'git cl presubmit'.

NOTRY=True
==========

[kjellander_webrtc, 2015-12-09 22:14:25]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2015-12-09 22:14:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1504283004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1504283004/20001

[kjellander_webrtc, 2015-12-09 22:15:31]

On 2015/12/09 22:06:32, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
>   win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

I added NOTRY=True to the CL description here which will make it skip trybots
for the CQ. 
There's no point running more than just a few compile trybots for CLs like this
(unless you change any logic, which you shouldn't need to to comply with
cpplint).

[commit-bot: I haz the power, 2015-12-09 22:18:17]

Description was changed from

==========
Enable cpplint for webrtc/examples and fix all uncovered cpplint errors.

BUG=webrtc:5273
TESTED=Fixed issues reported by:
find webrtc/examples/ -type f -name *.cc -o -name *.h | grep -v objc | xargs
cpplint.py
followed by 'git cl presubmit'.

NOTRY=True
==========

to

==========
Enable cpplint for webrtc/examples and fix all uncovered cpplint errors.

BUG=webrtc:5273
TESTED=Fixed issues reported by:
find webrtc/examples/ -type f -name *.cc -o -name *.h | grep -v objc | xargs
cpplint.py
followed by 'git cl presubmit'.

NOTRY=True
==========

[commit-bot: I haz the power, 2015-12-09 22:18:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-09 22:18:25]

Description was changed from

==========
Enable cpplint for webrtc/examples and fix all uncovered cpplint errors.

BUG=webrtc:5273
TESTED=Fixed issues reported by:
find webrtc/examples/ -type f -name *.cc -o -name *.h | grep -v objc | xargs
cpplint.py
followed by 'git cl presubmit'.

NOTRY=True
==========

to

==========
Enable cpplint for webrtc/examples and fix all uncovered cpplint errors.

BUG=webrtc:5273
TESTED=Fixed issues reported by:
find webrtc/examples/ -type f -name *.cc -o -name *.h | grep -v objc | xargs
cpplint.py
followed by 'git cl presubmit'.

NOTRY=True

Committed: https://crrev.com/70625e5bf3c91c57bf704d380bcc9df86575f08a
Cr-Commit-Position: refs/heads/master@{#10960}
==========

[commit-bot: I haz the power, 2015-12-09 22:18:26]

Patchset 2 (id:??) landed as
https://crrev.com/70625e5bf3c91c57bf704d380bcc9df86575f08a
Cr-Commit-Position: refs/heads/master@{#10960}