Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1503883002: Roll chromium_revision 626eecf..72c3265 (363027:363365) (Closed)

Created:
5 years ago by kjellander_webrtc
Modified:
5 years ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Roll chromium_revision 626eecf..72c3265 (363027:363365) https://chromium.googlesource.com/chromium/src/+/0c2a94ab87e6351b924a19932442e85a8f786fa0 needed the addition of tools/telemetry and third_party/catapult symlinks for Android. GN changes required modification of .gn. Change log: https://chromium.googlesource.com/chromium/src/+log/626eecf..72c3265 Full diff: https://chromium.googlesource.com/chromium/src/+/626eecf..72c3265 Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/818123d..b747a9e * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/fde89b4..6d9e5a7 DEPS diff: https://chromium.googlesource.com/chromium/src/+/626eecf..72c3265/DEPS No update to Clang. TBR= NOTRY=True Committed: https://crrev.com/34a7054fd68b0347e60c7529ae94b868a190f255 Cr-Commit-Position: refs/heads/master@{#10904}

Patch Set 1 #

Patch Set 2 : Added GN fix and tools/telemetry link #

Patch Set 3 : Adding third_party/catapult for Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M .gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M setup_links.py View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503883002/1
5 years ago (2015-12-06 11:02:51 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: android_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_rel/builds/7477) linux_gn_dbg on tryserver.webrtc (JOB_FAILED, ...
5 years ago (2015-12-06 11:06:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503883002/20001
5 years ago (2015-12-06 11:58:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503883002/40001
5 years ago (2015-12-06 18:29:07 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-06 18:32:38 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-06 18:32:49 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/34a7054fd68b0347e60c7529ae94b868a190f255
Cr-Commit-Position: refs/heads/master@{#10904}

Powered by Google App Engine
This is Rietveld 408576698