Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1503043003:
Deletes temporary files that are generated in several ACM unittests. (Closed)
|
Created:
5 years ago by ivoc Modified:
5 years ago Reviewers:
*hlundin-webrtc CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDeletes temporary files that are generated in several ACM unittests.
This applies to AcmSwitchingOutputFrequencyOldApi.*,
AcmReceiverBitExactnessOldApi.* and AcmSenderBitExactnessOldApi.*.
BUG=webrtc:4647
NOTRY=true
Committed: https://crrev.com/e10c82dc12cf51fbac83c0558bf5269b1aff50ee
Cr-Commit-Position: refs/heads/master@{#10936}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Changed from C++ to C version of remove calls. #Messages
Total messages: 17 (10 generated)
Description was changed from ========== Deletes temporary files that are generated in several ACM unittests. This applies to AcmSwitchingOutputFrequencyOldApi.*, AcmReceiverBitExactnessOldApi.* and AcmSenderBitExactnessOldApi.*. BUG=webrtc:4647 ========== to ========== Deletes temporary files that are generated in several ACM unittests. This applies to AcmSwitchingOutputFrequencyOldApi.*, AcmReceiverBitExactnessOldApi.* and AcmSenderBitExactnessOldApi.*. BUG=webrtc:4647 ==========
ivoc@webrtc.org changed reviewers: + henrik.lundin@webrtc.org
ivoc@webrtc.org changed required reviewers: + henrik.lundin@webrtc.org
Hi Henrik, have a look at this small fix.
lgtm with nit. https://codereview.webrtc.org/1503043003/diff/1/webrtc/modules/audio_coding/a... File webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc (right): https://codereview.webrtc.org/1503043003/diff/1/webrtc/modules/audio_coding/a... webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc:11: #include <stdio.h> You are including the C-header, but use the C++ std::remove. Please, change header or function call.
The CQ bit was checked by ivoc@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from henrik.lundin@webrtc.org Link to the patchset: https://codereview.webrtc.org/1503043003/#ps20001 (title: "Changed from C++ to C version of remove calls.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503043003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503043003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, no build URL)
Description was changed from ========== Deletes temporary files that are generated in several ACM unittests. This applies to AcmSwitchingOutputFrequencyOldApi.*, AcmReceiverBitExactnessOldApi.* and AcmSenderBitExactnessOldApi.*. BUG=webrtc:4647 ========== to ========== Deletes temporary files that are generated in several ACM unittests. This applies to AcmSwitchingOutputFrequencyOldApi.*, AcmReceiverBitExactnessOldApi.* and AcmSenderBitExactnessOldApi.*. BUG=webrtc:4647 NOTRY=true ==========
The CQ bit was checked by ivoc@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1503043003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1503043003/20001
Message was sent while issue was closed.
Description was changed from ========== Deletes temporary files that are generated in several ACM unittests. This applies to AcmSwitchingOutputFrequencyOldApi.*, AcmReceiverBitExactnessOldApi.* and AcmSenderBitExactnessOldApi.*. BUG=webrtc:4647 NOTRY=true ========== to ========== Deletes temporary files that are generated in several ACM unittests. This applies to AcmSwitchingOutputFrequencyOldApi.*, AcmReceiverBitExactnessOldApi.* and AcmSenderBitExactnessOldApi.*. BUG=webrtc:4647 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Deletes temporary files that are generated in several ACM unittests. This applies to AcmSwitchingOutputFrequencyOldApi.*, AcmReceiverBitExactnessOldApi.* and AcmSenderBitExactnessOldApi.*. BUG=webrtc:4647 NOTRY=true ========== to ========== Deletes temporary files that are generated in several ACM unittests. This applies to AcmSwitchingOutputFrequencyOldApi.*, AcmReceiverBitExactnessOldApi.* and AcmSenderBitExactnessOldApi.*. BUG=webrtc:4647 NOTRY=true Committed: https://crrev.com/e10c82dc12cf51fbac83c0558bf5269b1aff50ee Cr-Commit-Position: refs/heads/master@{#10936} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e10c82dc12cf51fbac83c0558bf5269b1aff50ee Cr-Commit-Position: refs/heads/master@{#10936} |
