Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1502993003: Use existing parser in ReceivesAndRetransmitsNack. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use existing parser in ReceivesAndRetransmitsNack. Removes logspam of "Failed to find extension id:". BUG= TBR=sprang@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/03671cb38a53b7d4f22545f5e58079a234f7cf27

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M webrtc/video/end_to_end_tests.cc View 2 chunks +1 line, -2 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
pbos-webrtc
PTAL
5 years ago (2015-12-07 14:03:12 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/03671cb38a53b7d4f22545f5e58079a234f7cf27 Cr-Commit-Position: refs/heads/master@{#10913}
5 years ago (2015-12-07 14:22:39 UTC) #5
pbos-webrtc
Committed patchset #1 (id:1) manually as 03671cb38a53b7d4f22545f5e58079a234f7cf27 (presubmit successful).
5 years ago (2015-12-07 14:22:41 UTC) #6
sprang_webrtc
https://codereview.webrtc.org/1502993003/diff/1/webrtc/video/end_to_end_tests.cc File webrtc/video/end_to_end_tests.cc (right): https://codereview.webrtc.org/1502993003/diff/1/webrtc/video/end_to_end_tests.cc#newcode447 webrtc/video/end_to_end_tests.cc:447: rtc::scoped_ptr<RtpHeaderParser> rtp_parser_; Now this is unused and should be ...
5 years ago (2015-12-07 14:37:15 UTC) #7
pbos-webrtc
5 years ago (2015-12-07 14:55:34 UTC) #8
Message was sent while issue was closed.
https://codereview.webrtc.org/1502993003/diff/1/webrtc/video/end_to_end_tests.cc
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/1502993003/diff/1/webrtc/video/end_to_end_tests...
webrtc/video/end_to_end_tests.cc:447: rtc::scoped_ptr<RtpHeaderParser>
rtp_parser_;
On 2015/12/07 14:37:15, språng wrote:
> Now this is unused and should be removed as well.

Sorry about that, https://codereview.webrtc.org/1506743003/

Powered by Google App Engine
This is Rietveld 408576698