Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1502223002: Don't call SetPreviewFormat if capturing to textures. (Closed)

Created:
5 years ago by perkj_webrtc
Modified:
5 years ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't call SetPreviewFormat if capturing to textures. This fix an issue seen on Huawei Y300 where the camera feed is black and white if we capture to textures and setpreviewformat is called. BUG=webrtc:4993 Committed: https://crrev.com/7b2f7627e4241cf0904f63ee6e94eeff3ba9b2e0 Cr-Commit-Position: refs/heads/master@{#10941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
perkj_webrtc
Please?
5 years ago (2015-12-07 14:48:45 UTC) #2
nisse-webrtc
On 2015/12/07 14:48:45, perkj1 wrote: > Please? LGTM.
5 years ago (2015-12-08 07:49:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502223002/1
5 years ago (2015-12-08 09:10:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/7764)
5 years ago (2015-12-08 10:12:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502223002/1
5 years ago (2015-12-08 18:15:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 20:03:04 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-08 20:03:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b2f7627e4241cf0904f63ee6e94eeff3ba9b2e0
Cr-Commit-Position: refs/heads/master@{#10941}

Powered by Google App Engine
This is Rietveld 408576698