Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1502183006: Removing DrMemory suppresssion on PushResampler. (Closed)

Created:
5 years ago by minyue-webrtc
Modified:
5 years ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing DrMemory suppresssion on PushResampler. BUG=webrtc:2321 R=kjellander@webrtc.org Committed: https://crrev.com/af3b9cb4d35ff56c0739c102de5bedae79fd7f04 Cr-Commit-Position: refs/heads/master@{#10950}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M tools/valgrind-webrtc/drmemory/suppressions.txt View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
minyue-webrtc
Hi Henrik, Would you review this?
5 years ago (2015-12-09 09:50:18 UTC) #3
kjellander_webrtc
lgtm the failing trybot is similar to https://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Full/builds/3307 which have then been fixed, so it's ...
5 years ago (2015-12-09 12:37:54 UTC) #4
minyue-webrtc
Committed patchset #2 (id:20001) manually as af3b9cb4d35ff56c0739c102de5bedae79fd7f04 (presubmit successful).
5 years ago (2015-12-09 12:52:15 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-09 12:52:19 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/af3b9cb4d35ff56c0739c102de5bedae79fd7f04
Cr-Commit-Position: refs/heads/master@{#10950}

Powered by Google App Engine
This is Rietveld 408576698