Wire up bandwidth limitation info to GetStats and adapt_reason.

Wire up bandwidth limitation info to GetStats and adapt_reason.

The input resolution (output from video_adapter) can be further scaled down or higher video layer(s) can be dropped due to bitrate constraints.

BUG=webrtc:4112
Committed: https://crrev.com/17821db19702aca15d0d93cb60515ca70823fad7
Cr-Commit-Position: refs/heads/master@{#11006}

[åsapersson, 2015-12-07 13:31:21]

Description was changed from

==========
Add bandwith limited reason to GetStats...

BUG=webrtc:4112
==========

to

==========
Wire up bandwidth limitation info to GetStats and adapt_reason.

The input resolution (output from video_adapter) can be further scaled down or
higher video layer(s) can be dropped due to bitrate constraints.

BUG=webrtc:4112
==========

[åsapersson, 2015-12-07 13:53:05]

Patchset #2 (id:20001) has been deleted

[åsapersson, 2015-12-07 13:53:21]

Patchset #1 (id:1) has been deleted

[åsapersson, 2015-12-07 13:59:55]

Patchset #1 (id:40001) has been deleted

[åsapersson, 2015-12-07 14:00:54]

asapersson@webrtc.org changed reviewers:
+ pbos@webrtc.org, stefan@webrtc.org

[pbos-webrtc, 2015-12-07 15:02:44]

lgtm

[stefan-webrtc, 2015-12-07 16:02:33]

https://codereview.webrtc.org/1502173002/diff/80001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/1502173002/diff/80001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvideoengine2.cc:2165: info.adapt_reason =
CoordinatedVideoAdapter::ADAPTREASON_BANDWIDTH;
Now this may overwrite any reason written on line 2155. Should we handle
multiple adapt reasons? Maybe not needed for now, but could be worth commenting
on.

[åsapersson, 2015-12-08 08:58:25]

https://codereview.webrtc.org/1502173002/diff/80001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/1502173002/diff/80001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvideoengine2.cc:2165: info.adapt_reason =
CoordinatedVideoAdapter::ADAPTREASON_BANDWIDTH;
On 2015/12/07 16:02:33, stefan-webrtc (holmer) wrote:
> Now this may overwrite any reason written on line 2155. Should we handle
> multiple adapt reasons? Maybe not needed for now, but could be worth
commenting
> on.

The video_adapter shows the most limiting reason (or several if having the same
limit). Updated comment that BW will be the most limiting if set and therefore
overwritten.

[åsapersson, 2015-12-11 14:39:38]

https://codereview.webrtc.org/1502173002/diff/80001/talk/media/webrtc/webrtcv...
File talk/media/webrtc/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/1502173002/diff/80001/talk/media/webrtc/webrtcv...
talk/media/webrtc/webrtcvideoengine2.cc:2165: info.adapt_reason =
CoordinatedVideoAdapter::ADAPTREASON_BANDWIDTH;
On 2015/12/08 08:58:25, åsapersson wrote:
> On 2015/12/07 16:02:33, stefan-webrtc (holmer) wrote:
> > Now this may overwrite any reason written on line 2155. Should we handle
> > multiple adapt reasons? Maybe not needed for now, but could be worth
> commenting
> > on.
> 
> The video_adapter shows the most limiting reason (or several if having the
same
> limit). Updated comment that BW will be the most limiting if set and therefore
> overwritten.

Have changed so BW is added (and does not overwrite reasons from video adapter).
PTAL.

[stefan-webrtc, 2015-12-11 14:52:46]

lgtm

[åsapersson, 2015-12-14 07:59:31]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2015-12-14 07:59:31]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org,
stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1502173002/#ps160001 (title:
" fix test")

[commit-bot: I haz the power, 2015-12-14 07:59:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502173002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502173002/160001

[commit-bot: I haz the power, 2015-12-14 08:07:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-14 08:07:14]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2382)

[åsapersson, 2015-12-14 08:21:59]

asapersson@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[mflodman, 2015-12-14 09:46:26]

LGTM

[åsapersson, 2015-12-14 10:06:14]

The CQ bit was checked by asapersson@webrtc.org

[commit-bot: I haz the power, 2015-12-14 10:06:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502173002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502173002/160001

[commit-bot: I haz the power, 2015-12-14 10:08:16]

Description was changed from

==========
Wire up bandwidth limitation info to GetStats and adapt_reason.

The input resolution (output from video_adapter) can be further scaled down or
higher video layer(s) can be dropped due to bitrate constraints.

BUG=webrtc:4112
==========

to

==========
Wire up bandwidth limitation info to GetStats and adapt_reason.

The input resolution (output from video_adapter) can be further scaled down or
higher video layer(s) can be dropped due to bitrate constraints.

BUG=webrtc:4112
==========

[commit-bot: I haz the power, 2015-12-14 10:08:17]

Committed patchset #6 (id:160001)

[commit-bot: I haz the power, 2015-12-14 10:08:28]

Description was changed from

==========
Wire up bandwidth limitation info to GetStats and adapt_reason.

The input resolution (output from video_adapter) can be further scaled down or
higher video layer(s) can be dropped due to bitrate constraints.

BUG=webrtc:4112
==========

to

==========
Wire up bandwidth limitation info to GetStats and adapt_reason.

The input resolution (output from video_adapter) can be further scaled down or
higher video layer(s) can be dropped due to bitrate constraints.

BUG=webrtc:4112

Committed: https://crrev.com/17821db19702aca15d0d93cb60515ca70823fad7
Cr-Commit-Position: refs/heads/master@{#11006}
==========

[commit-bot: I haz the power, 2015-12-14 10:08:29]

Patchset 6 (id:??) landed as
https://crrev.com/17821db19702aca15d0d93cb60515ca70823fad7
Cr-Commit-Position: refs/heads/master@{#11006}