Refactor handling of AudioOptions.

Refactor handling of AudioOptions.

- Remove MediaEngineInterface::GetAudioOptions(), SetAudioOptions() and SetSoundDevices().
- Remove the WebRtcVoiceEngine infrastructure for those calls.

BUG=webrtc:4690
TBR=pthatcher@webrtc.org

Committed: https://crrev.com/246b8171a6fbb4e37a5491679bc595238f81e490
Cr-Commit-Position: refs/heads/master@{#10938}

[pthatcher1, 2015-12-03 19:38:34]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2015-12-03 19:38:35]

It looks good, but I'll hold off on the "lgtm" until you've got the unit tests
done.

[pthatcher1, 2015-12-03 19:38:35]

It looks good, but I'll hold off on the "lgtm" until you've got the unit tests
done.

[the sun, 2015-12-03 19:41:13]

On 2015/12/03 19:38:35, pthatcher1 wrote:
> It looks good, but I'll hold off on the "lgtm" until you've got the unit tests
> done.

Haha, regexp match. :)

Don't worry, I'll fix the unit tests and wait for the real lgtm. :)

[pthatcher, 2015-12-03 19:47:43]

On 2015/12/03 19:41:13, the sun wrote:
> On 2015/12/03 19:38:35, pthatcher1 wrote:
> > It looks good, but I'll hold off on the "lgtm" until you've got the unit
tests
> > done.
> 
> Haha, regexp match. :)
> 
> Don't worry, I'll fix the unit tests and wait for the real lgtm. :)

It looks like an arms race.  Next time I'll have to try "L-G-T-M".

[the sun, 2015-12-04 11:00:16]

On 2015/12/03 19:47:43, pthatcher wrote:
> On 2015/12/03 19:41:13, the sun wrote:
> > On 2015/12/03 19:38:35, pthatcher1 wrote:
> > > It looks good, but I'll hold off on the "lgtm" until you've got the unit
> tests
> > > done.
> > 
> > Haha, regexp match. :)
> > 
> > Don't worry, I'll fix the unit tests and wait for the real lgtm. :)
> 
> It looks like an arms race.  Next time I'll have to try "L-G-T-M".

There we go, PTAL.

[the sun, 2015-12-04 16:33:47]

On 2015/12/04 11:00:16, the sun wrote:
> On 2015/12/03 19:47:43, pthatcher wrote:
> > On 2015/12/03 19:41:13, the sun wrote:
> > > On 2015/12/03 19:38:35, pthatcher1 wrote:
> > > > It looks good, but I'll hold off on the "lgtm" until you've got the unit
> > tests
> > > > done.
> > > 
> > > Haha, regexp match. :)
> > > 
> > > Don't worry, I'll fix the unit tests and wait for the real lgtm. :)
> > 
> > It looks like an arms race.  Next time I'll have to try "L-G-T-M".
> 
> There we go, PTAL.

It turned out moving the call to WVoE::SetDefaultDevices() (previously
SetDevices()) into WVoE::InitInternal() and actually checking the result caused
test failures, which set me off on a debug-on-bot detour. This is why
a) the many patch sets
b) SetDefaultDevices() is now pretty much empty. I weeded out the logic piece by
piece and AFAICT this is the actual code executed - please check if you agree!

[the sun, 2015-12-07 09:07:44]

On 2015/12/04 16:33:47, the sun wrote:
> On 2015/12/04 11:00:16, the sun wrote:
> > On 2015/12/03 19:47:43, pthatcher wrote:
> > > On 2015/12/03 19:41:13, the sun wrote:
> > > > On 2015/12/03 19:38:35, pthatcher1 wrote:
> > > > > It looks good, but I'll hold off on the "lgtm" until you've got the
unit
> > > tests
> > > > > done.
> > > > 
> > > > Haha, regexp match. :)
> > > > 
> > > > Don't worry, I'll fix the unit tests and wait for the real lgtm. :)
> > > 
> > > It looks like an arms race.  Next time I'll have to try "L-G-T-M".
> > 
> > There we go, PTAL.
> 
> It turned out moving the call to WVoE::SetDefaultDevices() (previously
> SetDevices()) into WVoE::InitInternal() and actually checking the result
caused
> test failures, which set me off on a debug-on-bot detour. This is why
> a) the many patch sets
> b) SetDefaultDevices() is now pretty much empty. I weeded out the logic piece
by
> piece and AFAICT this is the actual code executed - please check if you agree!

Ping...

[the sun, 2015-12-08 09:01:06]

solenberg@webrtc.org changed reviewers:
+ tommi@webrtc.org

[the sun, 2015-12-08 09:01:07]

Tommi, do you have time to take a look? I'd like to land this today.

[tommi, 2015-12-08 09:06:03]

lgtm! (+106 lines, -534 lines - nice!)

https://codereview.webrtc.org/1500633002/diff/260001/talk/media/webrtc/webrtc...
File talk/media/webrtc/webrtcvoiceengine.h (right):

https://codereview.webrtc.org/1500633002/diff/260001/talk/media/webrtc/webrtc...
talk/media/webrtc/webrtcvoiceengine.h:137: bool initialized_ = false;
nit: could group together with is_dumping_aec for slightly improved layout

[the sun, 2015-12-08 10:21:08]

https://codereview.webrtc.org/1500633002/diff/260001/talk/media/webrtc/webrtc...
File talk/media/webrtc/webrtcvoiceengine.h (right):

https://codereview.webrtc.org/1500633002/diff/260001/talk/media/webrtc/webrtc...
talk/media/webrtc/webrtcvoiceengine.h:137: bool initialized_ = false;
On 2015/12/08 09:06:03, tommi (webrtc) wrote:
> nit: could group together with is_dumping_aec for slightly improved layout

Done.

[the sun, 2015-12-08 10:29:05]

Description was changed from

==========
Refactor handling of AudioOptions.

- Remove MediaEngineInterface::GetAudioOptions(), SetAudioOptions() and
SetSoundDevices().
- Remove the WebRtcVoiceEngine infrastructure for those calls.

BUG=webrtc:4690
==========

to

==========
Refactor handling of AudioOptions.

- Remove MediaEngineInterface::GetAudioOptions(), SetAudioOptions() and
SetSoundDevices().
- Remove the WebRtcVoiceEngine infrastructure for those calls.

BUG=webrtc:4690
TBR=pthatcher@webrtc.org
==========

[the sun, 2015-12-08 10:29:11]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-12-08 10:29:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
pthatcher@webrtc.org, tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1500633002/#ps300001 (title:
"!")

[commit-bot: I haz the power, 2015-12-08 10:29:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1500633002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1500633002/300001

[commit-bot: I haz the power, 2015-12-08 11:34:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 11:34:53]

Try jobs failed on following builders:
  android_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/7445)

[the sun, 2015-12-08 15:50:38]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2015-12-08 15:50:38]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1500633002/#ps320001 (title:
"rebase")

[commit-bot: I haz the power, 2015-12-08 15:50:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1500633002/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1500633002/320001

[commit-bot: I haz the power, 2015-12-08 17:50:28]

Description was changed from

==========
Refactor handling of AudioOptions.

- Remove MediaEngineInterface::GetAudioOptions(), SetAudioOptions() and
SetSoundDevices().
- Remove the WebRtcVoiceEngine infrastructure for those calls.

BUG=webrtc:4690
TBR=pthatcher@webrtc.org
==========

to

==========
Refactor handling of AudioOptions.

- Remove MediaEngineInterface::GetAudioOptions(), SetAudioOptions() and
SetSoundDevices().
- Remove the WebRtcVoiceEngine infrastructure for those calls.

BUG=webrtc:4690
TBR=pthatcher@webrtc.org
==========

[commit-bot: I haz the power, 2015-12-08 17:50:29]

Committed patchset #17 (id:320001)

[commit-bot: I haz the power, 2015-12-08 17:50:42]

Description was changed from

==========
Refactor handling of AudioOptions.

- Remove MediaEngineInterface::GetAudioOptions(), SetAudioOptions() and
SetSoundDevices().
- Remove the WebRtcVoiceEngine infrastructure for those calls.

BUG=webrtc:4690
TBR=pthatcher@webrtc.org
==========

to

==========
Refactor handling of AudioOptions.

- Remove MediaEngineInterface::GetAudioOptions(), SetAudioOptions() and
SetSoundDevices().
- Remove the WebRtcVoiceEngine infrastructure for those calls.

BUG=webrtc:4690
TBR=pthatcher@webrtc.org

Committed: https://crrev.com/246b8171a6fbb4e37a5491679bc595238f81e490
Cr-Commit-Position: refs/heads/master@{#10938}
==========

[commit-bot: I haz the power, 2015-12-08 17:50:43]

Patchset 17 (id:??) landed as
https://crrev.com/246b8171a6fbb4e37a5491679bc595238f81e490
Cr-Commit-Position: refs/heads/master@{#10938}