Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1499653003: Add implementation and tests for RTCIceServer (Closed)

Created:
5 years ago by hjon
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update API for Objective-C RTCIceServer BUG= Committed: https://crrev.com/aa32c3e537643eb71d8a8cb8ea7089f8cda2098a Cr-Commit-Position: refs/heads/master@{#11000}

Patch Set 1 #

Patch Set 2 : Minor updates #

Total comments: 24

Patch Set 3 : Updates based on feedback #

Total comments: 16

Patch Set 4 : Updates from feedback #

Patch Set 5 : Update api_tests.gyp #

Total comments: 4

Patch Set 6 : Update gyp files #

Patch Set 7 : Rebase against master and fix sorting #

Patch Set 8 : Get rtc_base_objc build for Mac #

Patch Set 9 : Remove Mac support #

Patch Set 10 : Remove Mac from webrtc_tests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -14 lines) Patch
A + webrtc/api/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +17 lines, -5 lines 0 comments Download
A + webrtc/api/OWNERS View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A webrtc/api/api.gyp View 1 2 3 4 5 6 7 8 1 chunk +34 lines, -0 lines 2 comments Download
A webrtc/api/api_tests.gyp View 1 2 3 4 5 6 7 8 1 chunk +37 lines, -0 lines 0 comments Download
A + webrtc/api/objc/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A webrtc/api/objc/README View 1 chunk +3 lines, -0 lines 0 comments Download
A webrtc/api/objc/RTCIceServer.h View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
A webrtc/api/objc/RTCIceServer.mm View 1 2 3 1 chunk +64 lines, -0 lines 0 comments Download
A webrtc/api/objc/RTCIceServer+Private.h View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A + webrtc/api/objc/WebRTC-Prefix.pch View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
A webrtc/api/objctests/RTCIceServerTest.mm View 1 2 3 1 chunk +84 lines, -0 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/base/base.gyp View 1 2 3 4 5 6 7 8 1 chunk +17 lines, -2 lines 0 comments Download
A + webrtc/base/objc/NSString+StdString.h View 2 chunks +11 lines, -6 lines 0 comments Download
A webrtc/base/objc/NSString+StdString.mm View 1 chunk +25 lines, -0 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1517253005 Patch 1
Issue 1517253005 Patch 20001

Messages

Total messages: 23 (7 generated)
hjon
5 years ago (2015-12-03 22:34:56 UTC) #3
tkchin_webrtc
https://codereview.webrtc.org/1499653003/diff/20001/webrtc/api/BUILD.gn File webrtc/api/BUILD.gn (right): https://codereview.webrtc.org/1499653003/diff/20001/webrtc/api/BUILD.gn#newcode7 webrtc/api/BUILD.gn:7: # be found in the AUTHORS file in the ...
5 years ago (2015-12-04 20:17:10 UTC) #4
hjon
https://codereview.webrtc.org/1499653003/diff/20001/webrtc/api/BUILD.gn File webrtc/api/BUILD.gn (right): https://codereview.webrtc.org/1499653003/diff/20001/webrtc/api/BUILD.gn#newcode7 webrtc/api/BUILD.gn:7: # be found in the AUTHORS file in the ...
5 years ago (2015-12-07 20:03:53 UTC) #5
tkchin_webrtc
lgtm pthatcher@/tommi@ can you rubber stamp for new webrtc/api dir? kjellander@ mind checking the build ...
5 years ago (2015-12-08 19:04:02 UTC) #7
hjon
https://codereview.webrtc.org/1499653003/diff/40001/webrtc/api/BUILD.gn File webrtc/api/BUILD.gn (right): https://codereview.webrtc.org/1499653003/diff/40001/webrtc/api/BUILD.gn#newcode21 webrtc/api/BUILD.gn:21: "objc/Prefix.pch", On 2015/12/08 19:04:01, tkchin_webrtc wrote: > nit: Rename ...
5 years ago (2015-12-08 19:31:21 UTC) #8
hjon
5 years ago (2015-12-08 19:38:06 UTC) #9
kjellander_webrtc
*.gn+*.gyp: lgtm I can add the test right away to Mac, on iOS we'd be ...
5 years ago (2015-12-08 20:51:34 UTC) #10
hjon
https://codereview.webrtc.org/1499653003/diff/80001/webrtc/api/api.gyp File webrtc/api/api.gyp (right): https://codereview.webrtc.org/1499653003/diff/80001/webrtc/api/api.gyp#newcode32 webrtc/api/api.gyp:32: }], # OS=="ios" On 2015/12/08 20:51:34, kjellander (webrtc) wrote: ...
5 years ago (2015-12-08 21:00:41 UTC) #11
hjon
5 years ago (2015-12-08 22:01:41 UTC) #12
hjon
5 years ago (2015-12-08 22:27:18 UTC) #13
hjon
5 years ago (2015-12-08 22:29:27 UTC) #14
pthatcher1
lgtm https://codereview.webrtc.org/1499653003/diff/180001/webrtc/api/api.gyp File webrtc/api/api.gyp (right): https://codereview.webrtc.org/1499653003/diff/180001/webrtc/api/api.gyp#newcode15 webrtc/api/api.gyp:15: 'target_name': 'rtc_api_objc', Would just rtc_obj make more sense ...
5 years ago (2015-12-11 01:51:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499653003/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499653003/180001
5 years ago (2015-12-14 02:57:16 UTC) #18
tkchin_webrtc
https://codereview.webrtc.org/1499653003/diff/180001/webrtc/api/api.gyp File webrtc/api/api.gyp (right): https://codereview.webrtc.org/1499653003/diff/180001/webrtc/api/api.gyp#newcode15 webrtc/api/api.gyp:15: 'target_name': 'rtc_api_objc', On 2015/12/11 01:51:49, pthatcher1 wrote: > Would ...
5 years ago (2015-12-14 02:57:45 UTC) #19
commit-bot: I haz the power
Committed patchset #10 (id:180001)
5 years ago (2015-12-14 03:58:18 UTC) #21
commit-bot: I haz the power
5 years ago (2015-12-14 03:58:25 UTC) #23
Message was sent while issue was closed. 
Patchset 10 (id:??) landed as
https://crrev.com/aa32c3e537643eb71d8a8cb8ea7089f8cda2098a
Cr-Commit-Position: refs/heads/master@{#11000}

Powered by Google App Engine
This is Rietveld 408576698