Create fuzzer tests for audio decoders

Create fuzzer tests for audio decoders

This change adds fuzzer tests for iLBC, iSAC fix and float, and
Opus. The fuzzer function takes a random input vector and splits it
into a number of payloads. The lengths of the payloads is also
determined by the random vector. The payloads are decoded with the
decoders.

BUG=webrtc:5306
R=kjellander@webrtc.org, pbos@webrtc.org

Committed: https://crrev.com/fe32a76d6001d17c34ab597026fd1e16e5c3b9ea
Cr-Commit-Position: refs/heads/master@{#10932}

[hlundin-webrtc, 2015-12-04 09:34:30]

henrik.lundin@webrtc.org changed reviewers:
+ pbos@webrtc.org

[hlundin-webrtc, 2015-12-04 09:34:31]

pbos, please, take a look.

[pbos-webrtc, 2015-12-04 14:24:34]

Description was changed from

==========
Create fuzzer tests for audio decoders

This change adds fuzzer tests for iLBC, iSAC fix and float, and
Opus. The fuzzer function takes a random input vector and splits it
into a number of payloads. The lengths of the payloads is also
determined by the random vector. The payloads are decoded with the
decoders.

BUG=5306
==========

to

==========
Create fuzzer tests for audio decoders

This change adds fuzzer tests for iLBC, iSAC fix and float, and
Opus. The fuzzer function takes a random input vector and splits it
into a number of payloads. The lengths of the payloads is also
determined by the random vector. The payloads are decoded with the
decoders.

BUG=webrtc:5306
==========

[pbos-webrtc, 2015-12-04 14:27:25]

https://codereview.webrtc.org/1499093002/diff/1/webrtc/BUILD.gn
File webrtc/BUILD.gn (right):

https://codereview.webrtc.org/1499093002/diff/1/webrtc/BUILD.gn#newcode270
webrtc/BUILD.gn:270: "modules/rtp_rtcp",
Is this related?

https://codereview.webrtc.org/1499093002/diff/1/webrtc/BUILD.gn#newcode288
webrtc/BUILD.gn:288: # iLBC fuzzer disabled:
No need to disable, just because the fuzzer finds bugs doesn't mean it has to be
disabled.

https://codereview.webrtc.org/1499093002/diff/1/webrtc/test/fuzzers/BUILD.gn
File webrtc/test/fuzzers/BUILD.gn (right):

https://codereview.webrtc.org/1499093002/diff/1/webrtc/test/fuzzers/BUILD.gn#...
webrtc/test/fuzzers/BUILD.gn:74: "audio_decoder_fuzzer.cc",
Break out audio_decoder_fuzzer to its own source_set.

[hlundin-webrtc, 2015-12-04 14:56:55]

Taking care of review comments and adding a function comment

[hlundin-webrtc, 2015-12-04 14:58:06]

Thanks. PTAL again.

https://codereview.webrtc.org/1499093002/diff/1/webrtc/BUILD.gn
File webrtc/BUILD.gn (right):

https://codereview.webrtc.org/1499093002/diff/1/webrtc/BUILD.gn#newcode270
webrtc/BUILD.gn:270: "modules/rtp_rtcp",
On 2015/12/04 14:27:25, pbos-webrtc wrote:
> Is this related?

I thought it was...

https://codereview.webrtc.org/1499093002/diff/1/webrtc/BUILD.gn#newcode288
webrtc/BUILD.gn:288: # iLBC fuzzer disabled:
On 2015/12/04 14:27:25, pbos-webrtc wrote:
> No need to disable, just because the fuzzer finds bugs doesn't mean it has to
be
> disabled.

Done.

https://codereview.webrtc.org/1499093002/diff/1/webrtc/test/fuzzers/BUILD.gn
File webrtc/test/fuzzers/BUILD.gn (right):

https://codereview.webrtc.org/1499093002/diff/1/webrtc/test/fuzzers/BUILD.gn#...
webrtc/test/fuzzers/BUILD.gn:74: "audio_decoder_fuzzer.cc",
On 2015/12/04 14:27:25, pbos-webrtc wrote:
> Break out audio_decoder_fuzzer to its own source_set.

Done.

[pbos-webrtc, 2015-12-04 15:17:25]

lgtm, pref that you remove the comment in the ilbc fuzzer

https://codereview.webrtc.org/1499093002/diff/20001/webrtc/test/fuzzers/audio...
File webrtc/test/fuzzers/audio_decoder_ilbc_fuzzer.cc (right):

https://codereview.webrtc.org/1499093002/diff/20001/webrtc/test/fuzzers/audio...
webrtc/test/fuzzers/audio_decoder_ilbc_fuzzer.cc:14: // iLBC fuzzer is known to
cause failures.
Don't need this either I think, it'll be tracked by the bugs we file due to
clusterfuzz findings.

[hlundin-webrtc, 2015-12-04 15:21:16]

Remove comment

[hlundin-webrtc, 2015-12-04 15:22:07]

thanks

https://codereview.webrtc.org/1499093002/diff/20001/webrtc/test/fuzzers/audio...
File webrtc/test/fuzzers/audio_decoder_ilbc_fuzzer.cc (right):

https://codereview.webrtc.org/1499093002/diff/20001/webrtc/test/fuzzers/audio...
webrtc/test/fuzzers/audio_decoder_ilbc_fuzzer.cc:14: // iLBC fuzzer is known to
cause failures.
On 2015/12/04 15:17:25, pbos-webrtc wrote:
> Don't need this either I think, it'll be tracked by the bugs we file due to
> clusterfuzz findings.

Done.

[hlundin-webrtc, 2015-12-07 07:53:33]

henrik.lundin@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[hlundin-webrtc, 2015-12-07 07:53:33]

+kjellander to review webrtc/BUILD.gn.

[kjellander_webrtc, 2015-12-07 08:05:22]

https://codereview.webrtc.org/1499093002/diff/40001/webrtc/test/fuzzers/BUILD.gn
File webrtc/test/fuzzers/BUILD.gn (right):

https://codereview.webrtc.org/1499093002/diff/40001/webrtc/test/fuzzers/BUILD...
webrtc/test/fuzzers/BUILD.gn:64: # Suppress warnings from Chrome's Clang
plugins.
Do you need all these? Would it be too much to ask to fix the warnings instead
since this is a very small piece of code?

[pbos-webrtc, 2015-12-07 08:07:08]

https://codereview.webrtc.org/1499093002/diff/40001/webrtc/test/fuzzers/BUILD.gn
File webrtc/test/fuzzers/BUILD.gn (right):

https://codereview.webrtc.org/1499093002/diff/40001/webrtc/test/fuzzers/BUILD...
webrtc/test/fuzzers/BUILD.gn:64: # Suppress warnings from Chrome's Clang
plugins.
On 2015/12/07 08:05:22, kjellander (webrtc) wrote:
> Do you need all these? Would it be too much to ask to fix the warnings instead
> since this is a very small piece of code?

I assume that these are from audio_coding, and since these include stuff from
audio_coding they must suppress these warnings as well. :(

[hlundin-webrtc, 2015-12-07 08:14:48]

https://codereview.webrtc.org/1499093002/diff/40001/webrtc/test/fuzzers/BUILD.gn
File webrtc/test/fuzzers/BUILD.gn (right):

https://codereview.webrtc.org/1499093002/diff/40001/webrtc/test/fuzzers/BUILD...
webrtc/test/fuzzers/BUILD.gn:64: # Suppress warnings from Chrome's Clang
plugins.
On 2015/12/07 08:07:07, pbos-webrtc wrote:
> On 2015/12/07 08:05:22, kjellander (webrtc) wrote:
> > Do you need all these? Would it be too much to ask to fix the warnings
instead
> > since this is a very small piece of code?
> 
> I assume that these are from audio_coding, and since these include stuff from
> audio_coding they must suppress these warnings as well. :(

I simply copied from the vp8 and vp9 fuzzer targets above. Didn't try without
the suppressions.

[kjellander_webrtc, 2015-12-07 08:21:43]

lgtm

https://codereview.webrtc.org/1499093002/diff/40001/webrtc/test/fuzzers/BUILD.gn
File webrtc/test/fuzzers/BUILD.gn (right):

https://codereview.webrtc.org/1499093002/diff/40001/webrtc/test/fuzzers/BUILD...
webrtc/test/fuzzers/BUILD.gn:64: # Suppress warnings from Chrome's Clang
plugins.
On 2015/12/07 08:14:48, hlundin-webrtc wrote:
> On 2015/12/07 08:07:07, pbos-webrtc wrote:
> > On 2015/12/07 08:05:22, kjellander (webrtc) wrote:
> > > Do you need all these? Would it be too much to ask to fix the warnings
> instead
> > > since this is a very small piece of code?
> > 
> > I assume that these are from audio_coding, and since these include stuff
from
> > audio_coding they must suppress these warnings as well. :(
> 
> I simply copied from the vp8 and vp9 fuzzer targets above. Didn't try without
> the suppressions.

Fair enough. 
This being the FixIt week this sounds like a good candidate to work on. I added
bug 163 to the fixit bugs.

[hlundin-webrtc, 2015-12-08 09:46:26]

Add a public_configs element to webrtc_fuzzer_main

[hlundin-webrtc, 2015-12-08 09:49:17]

https://codereview.webrtc.org/1499093002/diff/40001/webrtc/test/fuzzers/BUILD.gn
File webrtc/test/fuzzers/BUILD.gn (right):

https://codereview.webrtc.org/1499093002/diff/40001/webrtc/test/fuzzers/BUILD...
webrtc/test/fuzzers/BUILD.gn:64: # Suppress warnings from Chrome's Clang
plugins.
On 2015/12/07 08:21:43, kjellander (webrtc) wrote:
> On 2015/12/07 08:14:48, hlundin-webrtc wrote:
> > On 2015/12/07 08:07:07, pbos-webrtc wrote:
> > > On 2015/12/07 08:05:22, kjellander (webrtc) wrote:
> > > > Do you need all these? Would it be too much to ask to fix the warnings
> > instead
> > > > since this is a very small piece of code?
> > > 
> > > I assume that these are from audio_coding, and since these include stuff
> from
> > > audio_coding they must suppress these warnings as well. :(
> > 
> > I simply copied from the vp8 and vp9 fuzzer targets above. Didn't try
without
> > the suppressions.
> 
> Fair enough. 
> This being the FixIt week this sounds like a good candidate to work on. I
added
> bug 163 to the fixit bugs.

Done.

https://codereview.webrtc.org/1499093002/diff/60001/webrtc/test/fuzzers/BUILD.gn
File webrtc/test/fuzzers/BUILD.gn (right):

https://codereview.webrtc.org/1499093002/diff/60001/webrtc/test/fuzzers/BUILD...
webrtc/test/fuzzers/BUILD.gn:13: public_configs = [
"../..:common_inherited_config" ]
Had to add this to make it build under Chromium.

[kjellander_webrtc, 2015-12-08 09:51:02]

On 2015/12/08 09:49:17, hlundin-webrtc wrote:
>
https://codereview.webrtc.org/1499093002/diff/40001/webrtc/test/fuzzers/BUILD.gn
> File webrtc/test/fuzzers/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/1499093002/diff/40001/webrtc/test/fuzzers/BUILD...
> webrtc/test/fuzzers/BUILD.gn:64: # Suppress warnings from Chrome's Clang
> plugins.
> On 2015/12/07 08:21:43, kjellander (webrtc) wrote:
> > On 2015/12/07 08:14:48, hlundin-webrtc wrote:
> > > On 2015/12/07 08:07:07, pbos-webrtc wrote:
> > > > On 2015/12/07 08:05:22, kjellander (webrtc) wrote:
> > > > > Do you need all these? Would it be too much to ask to fix the warnings
> > > instead
> > > > > since this is a very small piece of code?
> > > > 
> > > > I assume that these are from audio_coding, and since these include stuff
> > from
> > > > audio_coding they must suppress these warnings as well. :(
> > > 
> > > I simply copied from the vp8 and vp9 fuzzer targets above. Didn't try
> without
> > > the suppressions.
> > 
> > Fair enough. 
> > This being the FixIt week this sounds like a good candidate to work on. I
> added
> > bug 163 to the fixit bugs.
> 
> Done.
> 
>
https://codereview.webrtc.org/1499093002/diff/60001/webrtc/test/fuzzers/BUILD.gn
> File webrtc/test/fuzzers/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/1499093002/diff/60001/webrtc/test/fuzzers/BUILD...
> webrtc/test/fuzzers/BUILD.gn:13: public_configs = [
> "../..:common_inherited_config" ]
> Had to add this to make it build under Chromium.

Thanks! Still lgtm @ */BUILD.gn

[pbos-webrtc, 2015-12-08 10:24:11]

lgtm assuming this builds on both checkouts :)

[hlundin-webrtc, 2015-12-08 10:27:38]

Description was changed from

==========
Create fuzzer tests for audio decoders

This change adds fuzzer tests for iLBC, iSAC fix and float, and
Opus. The fuzzer function takes a random input vector and splits it
into a number of payloads. The lengths of the payloads is also
determined by the random vector. The payloads are decoded with the
decoders.

BUG=webrtc:5306
==========

to

==========
Create fuzzer tests for audio decoders

This change adds fuzzer tests for iLBC, iSAC fix and float, and
Opus. The fuzzer function takes a random input vector and splits it
into a number of payloads. The lengths of the payloads is also
determined by the random vector. The payloads are decoded with the
decoders.

BUG=webrtc:5306
R=kjellander@webrtc.org, pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/fe32a76d6001d17c34ab59702...
==========

[hlundin-webrtc, 2015-12-08 10:27:40]

Committed patchset #4 (id:60001) manually as
fe32a76d6001d17c34ab597026fd1e16e5c3b9ea (presubmit successful).

[commit-bot: I haz the power, 2015-12-08 10:27:43]

Description was changed from

==========
Create fuzzer tests for audio decoders

This change adds fuzzer tests for iLBC, iSAC fix and float, and
Opus. The fuzzer function takes a random input vector and splits it
into a number of payloads. The lengths of the payloads is also
determined by the random vector. The payloads are decoded with the
decoders.

BUG=webrtc:5306
R=kjellander@webrtc.org, pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/fe32a76d6001d17c34ab59702...
==========

to

==========
Create fuzzer tests for audio decoders

This change adds fuzzer tests for iLBC, iSAC fix and float, and
Opus. The fuzzer function takes a random input vector and splits it
into a number of payloads. The lengths of the payloads is also
determined by the random vector. The payloads are decoded with the
decoders.

BUG=webrtc:5306
R=kjellander@webrtc.org, pbos@webrtc.org

Committed: https://crrev.com/fe32a76d6001d17c34ab597026fd1e16e5c3b9ea
Cr-Commit-Position: refs/heads/master@{#10932}
==========

[commit-bot: I haz the power, 2015-12-08 10:27:43]

Patchset 4 (id:??) landed as
https://crrev.com/fe32a76d6001d17c34ab597026fd1e16e5c3b9ea
Cr-Commit-Position: refs/heads/master@{#10932}