Add ufrag to the ICE candidate signaling.

talk/app/webrtc/webrtcsdp.cc

Index: talk/app/webrtc/webrtcsdp.cc
diff --git a/talk/app/webrtc/webrtcsdp.cc b/talk/app/webrtc/webrtcsdp.cc
index bc5dc1d1da5caf69524b8d0d4bd4aa819640fb0f..05e001689eb8cc6efeef38fe6fb6a179658b2c3b 100644
--- a/talk/app/webrtc/webrtcsdp.cc
+++ b/talk/app/webrtc/webrtcsdp.cc
@@ -140,8 +140,6 @@ static const char kAttributeCandidate[] = "candidate";
 static const char kAttributeCandidateTyp[] = "typ";
 static const char kAttributeCandidateRaddr[] = "raddr";
 static const char kAttributeCandidateRport[] = "rport";
-static const char kAttributeCandidateUsername[] = "username";
-static const char kAttributeCandidatePassword[] = "password";
 static const char kAttributeCandidateGeneration[] = "generation";
 static const char kAttributeFingerprint[] = "fingerprint";
 static const char kAttributeSetup[] = "setup";
@@ -262,6 +260,7 @@ static void BuildRtpMap(const MediaContentDescription* media_desc,
                         const MediaType media_type,
                         std::string* message);
 static void BuildCandidate(const std::vector<Candidate>& candidates,
+                           bool include_ufrag,
                            std::string* message);
 static void BuildIceOptions(const std::vector<std::string>& transport_options,
                             std::string* message);
@@ -878,7 +877,7 @@ std::string SdpSerializeCandidate(
   std::string message;
   std::vector<cricket::Candidate> candidates;
   candidates.push_back(candidate.candidate());
-  BuildCandidate(candidates, &message);
+  BuildCandidate(candidates, true, &message);
   // From WebRTC draft section 4.8.1.1 candidate-attribute will be
   // just candidate:<candidate> not a=candidate:<blah>CRLF
   ASSERT(message.find("a=") == 0);
@@ -1072,10 +1071,8 @@ bool ParseCandidate(const std::string& message, Candidate* candidate,
   }
 
   // Extension
-  // Empty string as the candidate username and password.
-  // Will be updated later with the ice-ufrag and ice-pwd.
-  // TODO: Remove the username/password extension, which is currently
-  // kept for backwards compatibility.
+  // ice-ufrag is stored as username and ice-pwd is stored as password in
+  // the candidate.

[pthatcher1, 2015/12/10 22:08:06]

I think this comment would be more valuable as "Though non-standard, we support
the ICE ufrag and pwd being signaled on the candidate to avoid issues with
confusing which generation a candidate belongs to when trickling multiple
generations at the same time."

[honghaiz3, 2015/12/11 04:47:29]

Done.

   std::string username;
   std::string password;
   uint32_t generation = 0;
@@ -1086,9 +1083,9 @@ bool ParseCandidate(const std::string& message, Candidate* candidate,
       if (!GetValueFromString(first_line, fields[++i], &generation, error)) {
         return false;
       }
-    } else if (fields[i] == kAttributeCandidateUsername) {
+    } else if (fields[i] == kAttributeIceUfrag) {
       username = fields[++i];
-    } else if (fields[i] == kAttributeCandidatePassword) {
+    } else if (fields[i] == kAttributeIcePwd) {
       password = fields[++i];
     } else {
       // Skip the unknown extension.
@@ -1286,7 +1283,7 @@ void BuildMediaDescription(const ContentInfo* content_info,
   }
 
   // Build the a=candidate lines.
-  BuildCandidate(candidates, message);
+  BuildCandidate(candidates, false, message);

[pthatcher1, 2015/12/10 22:08:06]

Can you leave a comment like "We don't include the ufrag on candidates in the
SDP because it's redundant with the values already in the m-line."?

[honghaiz3, 2015/12/11 04:47:29]

Done.

 
   // Use the transport_info to build the media level ice-ufrag and ice-pwd.
   if (transport_info) {
@@ -1717,6 +1714,7 @@ void BuildRtpMap(const MediaContentDescription* media_desc,
 }
 
 void BuildCandidate(const std::vector<Candidate>& candidates,
+                    bool include_ufrag,
                     std::string* message) {
   std::ostringstream os;
 
@@ -1766,6 +1764,9 @@ void BuildCandidate(const std::vector<Candidate>& candidates,
 
     // Extensions
     os << kAttributeCandidateGeneration << " " << it->generation();
+    if (include_ufrag && !it->username().empty()) {
+      os << " " << kAttributeIceUfrag << " " << it->username();
+    }
 
     AddLine(os.str(), message);
   }
@@ -2677,7 +2678,8 @@ bool ParseContent(const std::string& message,
   // Update the candidates with the media level "ice-pwd" and "ice-ufrag".
   for (Candidates::iterator it = candidates_orig.begin();
        it != candidates_orig.end(); ++it) {
-    ASSERT((*it).username().empty());
+    ASSERT((*it).username().empty() ||
+           (*it).username() == transport->ice_ufrag);
     (*it).set_username(transport->ice_ufrag);
     ASSERT((*it).password().empty());
     (*it).set_password(transport->ice_pwd);