Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1498003002: Refactor EglBase configuration. (Closed)

Created:
5 years ago by nisse-webrtc
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Refactor EglBase configuration. Delete EglBase.ConfigType, instead pass arrays of attributes, and define constant arrays for the common cases. Both in progress NativeToI420 and extending GlRectDrawer to other shapes (with alpha) needs this. BUG=b/25694445 Committed: https://crrev.com/03f80ebb8310e5f04ced856f7ec8f14b94a0f47e Cr-Commit-Position: refs/heads/master@{#10908}

Patch Set 1 #

Messages

Total messages: 22 (11 generated)
nisse-webrtc
5 years ago (2015-12-04 12:03:57 UTC) #3
magjed_webrtc
lgtm
5 years ago (2015-12-04 12:26:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498003002/1
5 years ago (2015-12-04 12:26:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2183)
5 years ago (2015-12-04 12:37:32 UTC) #9
perkj_webrtc
lgtm
5 years ago (2015-12-04 13:01:10 UTC) #11
perkj_webrtc
lgtm
5 years ago (2015-12-04 13:01:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498003002/1
5 years ago (2015-12-04 13:01:25 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years ago (2015-12-04 14:03:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498003002/1
5 years ago (2015-12-07 08:08:52 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 09:17:20 UTC) #20
commit-bot: I haz the power
5 years ago (2015-12-07 09:17:26 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03f80ebb8310e5f04ced856f7ec8f14b94a0f47e
Cr-Commit-Position: refs/heads/master@{#10908}

Powered by Google App Engine
This is Rietveld 408576698