Add new view that renders local video using AVCaptureLayerPreview.

Add new view that renders local video using AVCaptureLayerPreview.

BUG=

Committed: https://crrev.com/edd8fefa9b31f903eefe1e9fcabb09a5d6fc1ad1
Cr-Commit-Position: refs/heads/master@{#10940}

[Chuck, 2015-12-04 22:06:18]

haysc@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[tkchin_webrtc, 2015-12-04 22:19:42]

https://codereview.webrtc.org/1497393002/diff/20001/talk/app/webrtc/objc/RTCA...
File talk/app/webrtc/objc/RTCAVFoundationVideoSource+Internal.h (right):

https://codereview.webrtc.org/1497393002/diff/20001/talk/app/webrtc/objc/RTCA...
talk/app/webrtc/objc/RTCAVFoundationVideoSource+Internal.h:35:
@property(nonatomic, readonly) dispatch_queue_t captureSessionQueue;
I think it's better to have all dispatch queues live in a single file in
webrtc/base/objc
But this is fine for now.

https://codereview.webrtc.org/1497393002/diff/20001/talk/app/webrtc/objc/RTCC...
File talk/app/webrtc/objc/RTCCameraPreviewView.mm (right):

https://codereview.webrtc.org/1497393002/diff/20001/talk/app/webrtc/objc/RTCC...
talk/app/webrtc/objc/RTCCameraPreviewView.mm:10: #if !defined(__has_feature) ||
!__has_feature(objc_arc)
nit: add blank line

https://codereview.webrtc.org/1497393002/diff/20001/talk/app/webrtc/objc/RTCC...
talk/app/webrtc/objc/RTCCameraPreviewView.mm:28: 
nit: remove blank line

https://codereview.webrtc.org/1497393002/diff/20001/talk/app/webrtc/objc/RTCC...
talk/app/webrtc/objc/RTCCameraPreviewView.mm:30: if (_videoSource ==
videoSource) {
Suggest not making this class depend on that particular video source, since we
only really need it just for the dispatch queue. Think this points at making a
common dispatch queue file.

[Chuck, 2015-12-05 00:21:23]

Updated per the design we discussed. New classes like in base/objc.

https://codereview.webrtc.org/1497393002/diff/20001/talk/app/webrtc/objc/RTCA...
File talk/app/webrtc/objc/RTCAVFoundationVideoSource+Internal.h (right):

https://codereview.webrtc.org/1497393002/diff/20001/talk/app/webrtc/objc/RTCA...
talk/app/webrtc/objc/RTCAVFoundationVideoSource+Internal.h:35:
@property(nonatomic, readonly) dispatch_queue_t captureSessionQueue;
On 2015/12/04 22:19:41, tkchin_webrtc wrote:
> I think it's better to have all dispatch queues live in a single file in
> webrtc/base/objc
> But this is fine for now.

Done.

https://codereview.webrtc.org/1497393002/diff/20001/talk/app/webrtc/objc/RTCC...
File talk/app/webrtc/objc/RTCCameraPreviewView.mm (right):

https://codereview.webrtc.org/1497393002/diff/20001/talk/app/webrtc/objc/RTCC...
talk/app/webrtc/objc/RTCCameraPreviewView.mm:10: #if !defined(__has_feature) ||
!__has_feature(objc_arc)
On 2015/12/04 22:19:42, tkchin_webrtc wrote:
> nit: add blank line

Done.

https://codereview.webrtc.org/1497393002/diff/20001/talk/app/webrtc/objc/RTCC...
talk/app/webrtc/objc/RTCCameraPreviewView.mm:28: 
On 2015/12/04 22:19:41, tkchin_webrtc wrote:
> nit: remove blank line

Done.

https://codereview.webrtc.org/1497393002/diff/20001/talk/app/webrtc/objc/RTCC...
talk/app/webrtc/objc/RTCCameraPreviewView.mm:30: if (_videoSource ==
videoSource) {
On 2015/12/04 22:19:41, tkchin_webrtc wrote:
> Suggest not making this class depend on that particular video source, since we
> only really need it just for the dispatch queue. Think this points at making a
> common dispatch queue file.

Done.

[tkchin_webrtc, 2015-12-07 18:27:07]

lgtm

https://codereview.webrtc.org/1497393002/diff/100001/talk/app/webrtc/objc/avf...
File talk/app/webrtc/objc/avfoundationvideocapturer.mm (right):

https://codereview.webrtc.org/1497393002/diff/100001/talk/app/webrtc/objc/avf...
talk/app/webrtc/objc/avfoundationvideocapturer.mm:31: #import
"webrtc/base/objc/RTCDispatcher.h"
nit: move this under the #import section

https://codereview.webrtc.org/1497393002/diff/100001/talk/build/merge_ios_lib...
File talk/build/merge_ios_libs.gyp (right):

https://codereview.webrtc.org/1497393002/diff/100001/talk/build/merge_ios_lib...
talk/build/merge_ios_libs.gyp:37: '<(webrtc_root)/base/base.gyp:rtc_base_objc',
mind adding a todo for moving this to webrtc/api/api.gyp:rtc_api_objc?

https://codereview.webrtc.org/1497393002/diff/100001/webrtc/base/objc/RTCCame...
File webrtc/base/objc/RTCCameraPreviewView.m (right):

https://codereview.webrtc.org/1497393002/diff/100001/webrtc/base/objc/RTCCame...
webrtc/base/objc/RTCCameraPreviewView.m:33: _captureSession = captureSession;
do we need the ivar?

https://codereview.webrtc.org/1497393002/diff/100001/webrtc/base/objc/RTCDisp...
File webrtc/base/objc/RTCDispatcher.h (right):

https://codereview.webrtc.org/1497393002/diff/100001/webrtc/base/objc/RTCDisp...
webrtc/base/objc/RTCDispatcher.h:13: typedef NS_ENUM(NSInteger,
RTCDispatcherType) {
nit: RTCDispatchQueueType

otherwise it sounds like there are multiple ways to dispatch, as opposed to one
way to dispatch on multiple things

https://codereview.webrtc.org/1497393002/diff/100001/webrtc/base/objc/RTCDisp...
webrtc/base/objc/RTCDispatcher.h:15: RTCDispatcherTypeMain,
is this the main queue?

https://codereview.webrtc.org/1497393002/diff/100001/webrtc/base/objc/RTCDisp...
webrtc/base/objc/RTCDispatcher.h:25: 
do we care about making init unavailable?

[Chuck, 2015-12-07 19:34:31]

https://codereview.webrtc.org/1497393002/diff/100001/talk/app/webrtc/objc/avf...
File talk/app/webrtc/objc/avfoundationvideocapturer.mm (right):

https://codereview.webrtc.org/1497393002/diff/100001/talk/app/webrtc/objc/avf...
talk/app/webrtc/objc/avfoundationvideocapturer.mm:31: #import
"webrtc/base/objc/RTCDispatcher.h"
On 2015/12/07 18:27:07, tkchin_webrtc wrote:
> nit: move this under the #import section

Done.

https://codereview.webrtc.org/1497393002/diff/100001/webrtc/base/objc/RTCCame...
File webrtc/base/objc/RTCCameraPreviewView.m (right):

https://codereview.webrtc.org/1497393002/diff/100001/webrtc/base/objc/RTCCame...
webrtc/base/objc/RTCCameraPreviewView.m:33: _captureSession = captureSession;
On 2015/12/07 18:27:07, tkchin_webrtc wrote:
> do we need the ivar?

I don't think we strictly need it, but we can't expose it as a property without
storing it, and we can't make assigning the same session again a no-op without
it.

https://codereview.webrtc.org/1497393002/diff/100001/webrtc/base/objc/RTCDisp...
File webrtc/base/objc/RTCDispatcher.h (right):

https://codereview.webrtc.org/1497393002/diff/100001/webrtc/base/objc/RTCDisp...
webrtc/base/objc/RTCDispatcher.h:13: typedef NS_ENUM(NSInteger,
RTCDispatcherType) {
On 2015/12/07 18:27:07, tkchin_webrtc wrote:
> nit: RTCDispatchQueueType
> 
> otherwise it sounds like there are multiple ways to dispatch, as opposed to
one
> way to dispatch on multiple things

Done.

https://codereview.webrtc.org/1497393002/diff/100001/webrtc/base/objc/RTCDisp...
webrtc/base/objc/RTCDispatcher.h:15: RTCDispatcherTypeMain,
On 2015/12/07 18:27:07, tkchin_webrtc wrote:
> is this the main queue?

Yes, seemed prudent to allow main queue through the same mechanism.

https://codereview.webrtc.org/1497393002/diff/100001/webrtc/base/objc/RTCDisp...
webrtc/base/objc/RTCDispatcher.h:25: 
On 2015/12/07 18:27:07, tkchin_webrtc wrote:
> do we care about making init unavailable?

Currently everything is static, so it shouldn't matter if someone creates an
instance. I'll make it unavailable for clarity.

[Chuck, 2015-12-07 20:03:15]

The CQ bit was checked by haysc@webrtc.org

[Chuck, 2015-12-07 20:03:15]

The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1497393002/#ps120001 (title:
"CR feedback")

[commit-bot: I haz the power, 2015-12-07 20:03:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497393002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497393002/120001

[commit-bot: I haz the power, 2015-12-07 20:05:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 20:05:02]

Try jobs failed on following builders:
  ios_arm64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/6130)

[Chuck, 2015-12-07 21:16:55]

The CQ bit was checked by haysc@webrtc.org

[Chuck, 2015-12-07 21:16:55]

The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1497393002/#ps160001 (title:
"Remove extra dependency line.")

[commit-bot: I haz the power, 2015-12-07 21:17:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497393002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497393002/160001

[commit-bot: I haz the power, 2015-12-07 21:24:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 21:24:21]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2255)

[Chuck, 2015-12-07 21:34:19]

haysc@webrtc.org changed reviewers:
+ jiayl@webrtc.org

[Chuck, 2015-12-07 21:34:20]

Looks like I need an LGTM from webrtc/base/OWNERS for the build changes in base.

[jiayl1, 2015-12-07 22:50:53]

jiayl@google.com changed reviewers:
+ jiayl@google.com

[jiayl1, 2015-12-07 22:50:53]

https://codereview.webrtc.org/1497393002/diff/160001/webrtc/base/objc/RTCDisp...
File webrtc/base/objc/RTCDispatcher.m (right):

https://codereview.webrtc.org/1497393002/diff/160001/webrtc/base/objc/RTCDisp...
webrtc/base/objc/RTCDispatcher.m:23:
"com.google.webrtc.RTCDispatcherCaptureSession",
Should this be "org.webrtc.XXX"?

[Chuck, 2015-12-07 23:02:16]

https://codereview.webrtc.org/1497393002/diff/160001/webrtc/base/objc/RTCDisp...
File webrtc/base/objc/RTCDispatcher.m (right):

https://codereview.webrtc.org/1497393002/diff/160001/webrtc/base/objc/RTCDisp...
webrtc/base/objc/RTCDispatcher.m:23:
"com.google.webrtc.RTCDispatcherCaptureSession",
On 2015/12/07 22:50:53, jiayl1 wrote:
> Should this be "org.webrtc.XXX"?

Seems reasonable. I moved this code from
talk/app/webrtc/objc/avfoundationvideocapturer.mm to here.

[Chuck, 2015-12-07 23:03:51]

https://codereview.webrtc.org/1497393002/diff/160001/webrtc/base/objc/RTCDisp...
File webrtc/base/objc/RTCDispatcher.m (right):

https://codereview.webrtc.org/1497393002/diff/160001/webrtc/base/objc/RTCDisp...
webrtc/base/objc/RTCDispatcher.m:23:
"com.google.webrtc.RTCDispatcherCaptureSession",
On 2015/12/07 23:02:16, Chuck wrote:
> On 2015/12/07 22:50:53, jiayl1 wrote:
> > Should this be "org.webrtc.XXX"?
> 
> Seems reasonable. I moved this code from
> talk/app/webrtc/objc/avfoundationvideocapturer.mm to here.

Oops, my reply may have been ambiguous, I changed the identifier to what you
suggested. Was just explaining where the code came from originally.

[jiayl2, 2015-12-07 23:04:33]

lgtm

[Chuck, 2015-12-07 23:10:40]

The CQ bit was checked by haysc@webrtc.org

[Chuck, 2015-12-07 23:10:41]

The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1497393002/#ps180001 (title:
"Change identifier")

[commit-bot: I haz the power, 2015-12-07 23:10:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497393002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497393002/180001

[commit-bot: I haz the power, 2015-12-07 23:12:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 23:12:58]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2257)

[tkchin_webrtc, 2015-12-08 00:36:11]

https://codereview.webrtc.org/1497393002/diff/180001/webrtc/base/objc/RTCDisp...
File webrtc/base/objc/RTCDispatcher.m (right):

https://codereview.webrtc.org/1497393002/diff/180001/webrtc/base/objc/RTCDisp...
webrtc/base/objc/RTCDispatcher.m:23: "org.webrtc.RTCDispatcherCaptureSession",
No don't do this. org is a java convention. Please use com.google.webrtc to be
consistent with iOS.

[jiayl1, 2015-12-08 00:38:30]

On 2015/12/08 00:36:11, tkchin_webrtc wrote:
>
https://codereview.webrtc.org/1497393002/diff/180001/webrtc/base/objc/RTCDisp...
> File webrtc/base/objc/RTCDispatcher.m (right):
> 
>
https://codereview.webrtc.org/1497393002/diff/180001/webrtc/base/objc/RTCDisp...
> webrtc/base/objc/RTCDispatcher.m:23: "org.webrtc.RTCDispatcherCaptureSession",
> No don't do this. org is a java convention. Please use com.google.webrtc to be
> consistent with iOS.

I doubt com.google.webrtc is the right thing, since this is an open source
project and should not have a google brand.

[tkchin_webrtc, 2015-12-08 00:43:23]

On 2015/12/08 00:38:30, jiayl1 wrote:
> On 2015/12/08 00:36:11, tkchin_webrtc wrote:
> >
>
https://codereview.webrtc.org/1497393002/diff/180001/webrtc/base/objc/RTCDisp...
> > File webrtc/base/objc/RTCDispatcher.m (right):
> > 
> >
>
https://codereview.webrtc.org/1497393002/diff/180001/webrtc/base/objc/RTCDisp...
> > webrtc/base/objc/RTCDispatcher.m:23:
"org.webrtc.RTCDispatcherCaptureSession",
> > No don't do this. org is a java convention. Please use com.google.webrtc to
be
> > consistent with iOS.
> 
> I doubt com.google.webrtc is the right thing, since this is an open source
> project and should not have a google brand.

Yeah you're right. org.webrtc it is.

[Chuck, 2015-12-08 00:58:24]

haysc@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[Chuck, 2015-12-08 00:58:24]

Henrik, need your approval for removing a duplicated check line from the
presubmit.py script.

tkchin modified the check here:
https://chromium.googlesource.com/external/webrtc/+/42f580e490e8343a87362dbb2...

and it got duplicated here:
https://chromium.googlesource.com/external/webrtc/+/53047c973%5E%21/#F0

I removed the duplicated one that didn't have the filter for objc.

[kjellander_webrtc, 2015-12-08 06:29:24]

PRESUBMIT.py: lgtm. Sorry about that one!

[Chuck, 2015-12-08 16:46:27]

The CQ bit was checked by haysc@webrtc.org

[Chuck, 2015-12-08 16:46:27]

The patchset sent to the CQ was uploaded after l-g-t-m from jiayl@webrtc.org,
tkchin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1497393002/#ps220001 (title:
"Removing duplicated check in presubmit.py")

[commit-bot: I haz the power, 2015-12-08 16:46:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497393002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497393002/220001

[commit-bot: I haz the power, 2015-12-08 19:08:43]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2015-12-08 19:08:46]

Description was changed from

==========
Add new view that renders local video using AVCaptureLayerPreview.

BUG=
==========

to

==========
Add new view that renders local video using AVCaptureLayerPreview.

BUG=

Committed: https://crrev.com/edd8fefa9b31f903eefe1e9fcabb09a5d6fc1ad1
Cr-Commit-Position: refs/heads/master@{#10940}
==========

[commit-bot: I haz the power, 2015-12-08 19:08:47]

Patchset 12 (id:??) landed as
https://crrev.com/edd8fefa9b31f903eefe1e9fcabb09a5d6fc1ad1
Cr-Commit-Position: refs/heads/master@{#10940}