webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc - Issue 1496883002: rtcp::Rrtr block moved into own file and got Parse function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc

Issue 1496883002: rtcp::Rrtr block moved into own file and got Parse function (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr_unittest.cc ('K') | « webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc

index 1743d99c5006befb27adddecd579af720ec4c1b3..be444e5ce4ebf0f2fa7b36a61b9e779dedd54679 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc

@@ -759,8 +759,7 @@ TEST(RtcpPacketTest, XrWithNoReportBlocks) {

TEST(RtcpPacketTest, XrWithRrtr) {

Rrtr rrtr;

- rrtr.WithNtpSec(0x11111111);

- rrtr.WithNtpFrac(0x22222222);

+ rrtr.WithNtp(NtpTime(0x11111111, 0x22222222));

Xr xr;

xr.From(kSenderSsrc);

EXPECT_TRUE(xr.WithRrtr(&rrtr));

@@ -777,11 +776,9 @@ TEST(RtcpPacketTest, XrWithRrtr) {

TEST(RtcpPacketTest, XrWithTwoRrtrBlocks) {

Rrtr rrtr1;

- rrtr1.WithNtpSec(0x11111111);

- rrtr1.WithNtpFrac(0x22222222);

+ rrtr1.WithNtp(NtpTime(0x11111111, 0x22222222));

Rrtr rrtr2;

- rrtr2.WithNtpSec(0x33333333);

- rrtr2.WithNtpFrac(0x44444444);

+ rrtr2.WithNtp(NtpTime(0x33333333, 0x44444444));

Xr xr;

xr.From(kSenderSsrc);

EXPECT_TRUE(xr.WithRrtr(&rrtr1));