rtcp::Rrtr block moved into own file and got Parse function

rtcp::Rrtr block moved into own file and got Parse function

BUG=webrtc:5260
R=asapersson@webrtc.org, åsapersson

[åsapersson, 2015-12-04 15:09:57]

https://codereview.webrtc.org/1496883002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr.cc (right):

https://codereview.webrtc.org/1496883002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr.cc:33:
RTC_DCHECK(ByteReader<uint16_t>::ReadBigEndian(&buffer[2]) == kBlockLength);
return false if block length is not 2?

https://codereview.webrtc.org/1496883002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr.cc:34: uint32_t seconds =
ByteReader<uint32_t>::ReadBigEndian(&buffer[4]);
I assume the buffer length will be verified before calling this function.

https://codereview.webrtc.org/1496883002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr_unittest.cc (right):

https://codereview.webrtc.org/1496883002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr_unittest.cc:25: const size_t
kBlockLength = sizeof(kBlock);
maybe call something else to not mix up with kBlockLength=2

https://codereview.webrtc.org/1496883002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr_unittest.cc:28: "Size of
manually created Voip Metric block should match class constant");
s/Voip Metric/RRTR

[danilchap, 2015-12-04 15:30:16]

https://codereview.webrtc.org/1496883002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr.cc (right):

https://codereview.webrtc.org/1496883002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr.cc:33:
RTC_DCHECK(ByteReader<uint16_t>::ReadBigEndian(&buffer[2]) == kBlockLength);
On 2015/12/04 15:09:57, åsapersson wrote:
> return false if block length is not 2?

Acknowledged.

https://codereview.webrtc.org/1496883002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr.cc:34: uint32_t seconds =
ByteReader<uint32_t>::ReadBigEndian(&buffer[4]);
On 2015/12/04 15:09:57, åsapersson wrote:
> I assume the buffer length will be verified before calling this function.

Yes. Extended Report parser would need to read block type/length anyway. It
would be up to it to verify length.

https://codereview.webrtc.org/1496883002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr_unittest.cc (right):

https://codereview.webrtc.org/1496883002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr_unittest.cc:25: const size_t
kBlockLength = sizeof(kBlock);
On 2015/12/04 15:09:57, åsapersson wrote:
> maybe call something else to not mix up with kBlockLength=2

Done.

https://codereview.webrtc.org/1496883002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr_unittest.cc:28: "Size of
manually created Voip Metric block should match class constant");
On 2015/12/04 15:09:57, åsapersson wrote:
> s/Voip Metric/RRTR

Oops. Failed to hide sometimes I use copy/paste method to write code.

[åsapersson, 2015-12-07 09:48:34]

lgtm

[danilchap, 2015-12-07 09:55:38]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2015-12-07 09:55:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1496883002/#ps40001 (title:
"rebase")

[commit-bot: I haz the power, 2015-12-07 09:55:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496883002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496883002/40001

[commit-bot: I haz the power, 2015-12-07 09:56:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 09:56:55]

Try jobs failed on following builders:
  linux_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn_dbg/builds/7284)
  mac_x64_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_x64_gn_dbg/builds/5759)
  mac_x64_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_x64_gn_rel/builds/5715)

[danilchap, 2015-12-07 10:38:39]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2015-12-07 10:38:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1496883002/#ps60001 (title:
"fix merge conflict (properly)")

[commit-bot: I haz the power, 2015-12-07 10:38:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496883002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496883002/60001

[commit-bot: I haz the power, 2015-12-07 10:42:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 10:42:07]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2233)

[commit-bot: I haz the power, 2015-12-07 13:46:49]

Description was changed from

==========
rtcp::Rrtr block moved into own file and got Parse function

BUG=webrtc:5260
R=åsapersson
==========

to

==========
rtcp::Rrtr block moved into own file and got Parse function

BUG=webrtc:5260
R=asapersson@webrtc.org, åsapersson

Committed: https://crrev.com/fc47ed6c0524d7ee0bc7947f0ad65fcefda34a29
Cr-Commit-Position: refs/heads/master@{#10912}
==========

[commit-bot: I haz the power, 2015-12-07 13:46:50]

Patchset 5 (id:??) landed as
https://crrev.com/fc47ed6c0524d7ee0bc7947f0ad65fcefda34a29
Cr-Commit-Position: refs/heads/master@{#10912}

[danilchap, 2015-12-07 13:52:01]

Description was changed from

==========
rtcp::Rrtr block moved into own file and got Parse function

BUG=webrtc:5260
R=asapersson@webrtc.org, åsapersson

Committed: https://crrev.com/fc47ed6c0524d7ee0bc7947f0ad65fcefda34a29
Cr-Commit-Position: refs/heads/master@{#10912}
==========

to

==========
rtcp::Rrtr block moved into own file and got Parse function

BUG=webrtc:5260
R=asapersson@webrtc.org, åsapersson
==========

[danilchap, 2015-12-07 13:52:03]

Committed patchset #5 (id:80001) to pending queue manually as
bc2c3505bf79b0840b41bb3efd45c1fd95152db4 (presubmit successful).