Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 1496883002: rtcp::Rrtr block moved into own file and got Parse function (Closed)

Created:
5 years ago by danilchap
Modified:
5 years ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

rtcp::Rrtr block moved into own file and got Parse function BUG=webrtc:5260 R=asapersson@webrtc.org, åsapersson

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : fix merge conflict (properly) #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -82 lines) Patch
M webrtc/modules/modules.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/rtp_rtcp.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.h View 1 2 4 chunks +3 lines, -39 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.cc View 1 2 3 chunks +6 lines, -28 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr.h View 1 chunk +49 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr_unittest.cc View 1 1 chunk +51 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet_unittest.cc View 1 2 2 chunks +3 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 1 2 2 chunks +5 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
danilchap
5 years ago (2015-12-03 09:27:06 UTC) #1
åsapersson
https://codereview.webrtc.org/1496883002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr.cc File webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr.cc (right): https://codereview.webrtc.org/1496883002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr.cc#newcode33 webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr.cc:33: RTC_DCHECK(ByteReader<uint16_t>::ReadBigEndian(&buffer[2]) == kBlockLength); return false if block length is ...
5 years ago (2015-12-04 15:09:57 UTC) #2
danilchap
https://codereview.webrtc.org/1496883002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr.cc File webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr.cc (right): https://codereview.webrtc.org/1496883002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr.cc#newcode33 webrtc/modules/rtp_rtcp/source/rtcp_packet/rrtr.cc:33: RTC_DCHECK(ByteReader<uint16_t>::ReadBigEndian(&buffer[2]) == kBlockLength); On 2015/12/04 15:09:57, åsapersson wrote: > ...
5 years ago (2015-12-04 15:30:16 UTC) #3
åsapersson
lgtm
5 years ago (2015-12-07 09:48:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496883002/40001
5 years ago (2015-12-07 09:55:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gn_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn_dbg/builds/7284) mac_x64_gn_dbg on tryserver.webrtc (JOB_FAILED, ...
5 years ago (2015-12-07 09:56:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496883002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496883002/60001
5 years ago (2015-12-07 10:38:47 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2233)
5 years ago (2015-12-07 10:42:07 UTC) #14
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/fc47ed6c0524d7ee0bc7947f0ad65fcefda34a29 Cr-Commit-Position: refs/heads/master@{#10912}
5 years ago (2015-12-07 13:46:50 UTC) #16
danilchap
5 years ago (2015-12-07 13:52:03 UTC) #18
Message was sent while issue was closed.
Committed patchset #5 (id:80001) to pending queue manually as
bc2c3505bf79b0840b41bb3efd45c1fd95152db4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698