Discard old-generation candidates when ICE restarts

Discard old-generation candidates when ICE restarts
The existing code only do so on the controlled side.

BUG=webrtc:5291
R=pthatcher@webrtc.org

Committed: https://crrev.com/04e9146e58bd68339b15ad651c9ee593d781e040
Cr-Commit-Position: refs/heads/master@{#10993}

[honghaiz3, 2015-12-02 23:24:44]

Patchset #1 (id:1) has been deleted

[honghaiz3, 2015-12-02 23:28:12]

Patchset #1 (id:20001) has been deleted

[honghaiz3, 2015-12-02 23:28:45]

honghaiz@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2015-12-11 01:49:01]

lgtm, with slight readability fix

https://codereview.webrtc.org/1496693002/diff/40001/talk/app/webrtc/webrtcses...
File talk/app/webrtc/webrtcsession.cc (right):

https://codereview.webrtc.org/1496693002/diff/40001/talk/app/webrtc/webrtcses...
talk/app/webrtc/webrtcsession.cc:529: break;
I think it would be more clear to put this here:

if (new_desc->type() == SessionDescriptionInterface::kOffer) {
  ice_restart_ = true;
}
return true;


(And then return false at the end).

[honghaiz3, 2015-12-11 18:44:45]

Patchset #2 (id:60001) has been deleted

[honghaiz3, 2015-12-11 18:44:55]

Patchset #2 (id:80001) has been deleted

[honghaiz3, 2015-12-11 18:45:44]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2015-12-11 18:45:44]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1496693002/#ps100001 (title:
" ")

[commit-bot: I haz the power, 2015-12-11 18:45:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496693002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496693002/100001

[honghaiz3, 2015-12-11 18:46:10]

Thanks!

https://codereview.webrtc.org/1496693002/diff/40001/talk/app/webrtc/webrtcses...
File talk/app/webrtc/webrtcsession.cc (right):

https://codereview.webrtc.org/1496693002/diff/40001/talk/app/webrtc/webrtcses...
talk/app/webrtc/webrtcsession.cc:529: break;
On 2015/12/11 01:49:00, pthatcher1 wrote:
> I think it would be more clear to put this here:
> 
> if (new_desc->type() == SessionDescriptionInterface::kOffer) {
>   ice_restart_ = true;
> }
> return true;
> 
> 
> (And then return false at the end).

Done.

[commit-bot: I haz the power, 2015-12-11 20:46:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-11 20:46:13]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[honghaiz3, 2015-12-11 22:26:47]

Description was changed from

==========
Discard old-generation candidates when ICE restarts
The existing code only do so on the controlled side.

BUG=webrtc:5291
==========

to

==========
Discard old-generation candidates when ICE restarts
The existing code only do so on the controlled side.

BUG=webrtc:5291
R=pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/04e9146e58bd68339b15ad651...
==========

[commit-bot: I haz the power, 2015-12-11 22:26:47]

Description was changed from

==========
Discard old-generation candidates when ICE restarts
The existing code only do so on the controlled side.

BUG=webrtc:5291
R=pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/04e9146e58bd68339b15ad651...
==========

to

==========
Discard old-generation candidates when ICE restarts
The existing code only do so on the controlled side.

BUG=webrtc:5291
R=pthatcher@webrtc.org

Committed: https://crrev.com/04e9146e58bd68339b15ad651c9ee593d781e040
Cr-Commit-Position: refs/heads/master@{#10993}
==========

[honghaiz3, 2015-12-11 22:26:48]

Committed patchset #2 (id:100001) manually as
04e9146e58bd68339b15ad651c9ee593d781e040 (presubmit successful).

[commit-bot: I haz the power, 2015-12-11 22:26:48]

Patchset 2 (id:??) landed as
https://crrev.com/04e9146e58bd68339b15ad651c9ee593d781e040
Cr-Commit-Position: refs/heads/master@{#10993}