|
|
DescriptionRemoves MAYBE_ from several test case names in JsepPeerConnectionP2PTestClient.
BUG=webrtc:5231
R=kjellander@webrtc.org, perkj@webrtc.org
Committed: https://chromium.googlesource.com/external/webrtc/+/9cf0c3d4ddfab865dcf924155cc81b763c919a53
Patch Set 1 #
Messages
Total messages: 22 (11 generated)
Description was changed from ========== Removes MAYBE_ from several test case names in JsepPeerConnectionP2PTestClient. BUG= ========== to ========== Removes MAYBE_ from several test case names in JsepPeerConnectionP2PTestClient. BUG=webrtc:5231 ==========
ivoc@webrtc.org changed reviewers: + kjellander@webrtc.org
ivoc@webrtc.org changed required reviewers: + kjellander@webrtc.org
Hi kjellander, here's the promised follow-up CL to fix the test-case names in the JsepPeerConnectionP2PTestClient tests.
lgtm
The CQ bit was checked by ivoc@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495853002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2133)
ivoc@webrtc.org changed reviewers: + perkj@webrtc.org
ivoc@webrtc.org changed required reviewers: + perkj@webrtc.org
Hi Perkj, please have a look at this small CL to fix the names of several test cases (that I messed up myself while sheriffing).
The CQ bit was checked by perkj@webrtc.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495853002/1
On 2015/12/04 06:50:58, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1495853002/1 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/1495853002/1 No need to waste trybot resources on a trivial patch like this. At most a few compile-only bots would be sufficient.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) presubmit on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Message was sent while issue was closed.
Description was changed from ========== Removes MAYBE_ from several test case names in JsepPeerConnectionP2PTestClient. BUG=webrtc:5231 ========== to ========== Removes MAYBE_ from several test case names in JsepPeerConnectionP2PTestClient. BUG=webrtc:5231 R=kjellander@webrtc.org, perkj@webrtc.org Committed: https://crrev.com/9cf0c3d4ddfab865dcf924155cc81b763c919a53 Cr-Commit-Position: refs/heads/master@{#10887} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9cf0c3d4ddfab865dcf924155cc81b763c919a53 Cr-Commit-Position: refs/heads/master@{#10887}
Message was sent while issue was closed.
Description was changed from ========== Removes MAYBE_ from several test case names in JsepPeerConnectionP2PTestClient. BUG=webrtc:5231 R=kjellander@webrtc.org, perkj@webrtc.org Committed: https://crrev.com/9cf0c3d4ddfab865dcf924155cc81b763c919a53 Cr-Commit-Position: refs/heads/master@{#10887} ========== to ========== Removes MAYBE_ from several test case names in JsepPeerConnectionP2PTestClient. BUG=webrtc:5231 R=kjellander@webrtc.org, perkj@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/9cf0c3d4ddfab865dcf924155... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 9cf0c3d4ddfab865dcf924155cc81b763c919a53 (presubmit successful). |