Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1495853002: Removes MAYBE_ from several test case names in JsepPeerConnectionP2PTestClient. (Closed)

Created:
5 years ago by ivoc
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removes MAYBE_ from several test case names in JsepPeerConnectionP2PTestClient. BUG=webrtc:5231 R=kjellander@webrtc.org, perkj@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/9cf0c3d4ddfab865dcf924155cc81b763c919a53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M talk/app/webrtc/peerconnection_unittest.cc View 7 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
ivoc
Hi kjellander, here's the promised follow-up CL to fix the test-case names in the JsepPeerConnectionP2PTestClient ...
5 years ago (2015-12-03 10:03:35 UTC) #4
kjellander_webrtc
lgtm
5 years ago (2015-12-03 10:12:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495853002/1
5 years ago (2015-12-03 10:35:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/2133)
5 years ago (2015-12-03 10:41:16 UTC) #9
ivoc
Hi Perkj, please have a look at this small CL to fix the names of ...
5 years ago (2015-12-03 10:58:42 UTC) #12
perkj_webrtc
lgtm
5 years ago (2015-12-04 06:50:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495853002/1
5 years ago (2015-12-04 06:50:58 UTC) #15
kjellander_webrtc
On 2015/12/04 06:50:58, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years ago (2015-12-04 08:05:02 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) mac_baremetal on ...
5 years ago (2015-12-04 08:51:14 UTC) #18
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9cf0c3d4ddfab865dcf924155cc81b763c919a53 Cr-Commit-Position: refs/heads/master@{#10887}
5 years ago (2015-12-04 09:37:14 UTC) #20
ivoc
5 years ago (2015-12-04 09:37:16 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9cf0c3d4ddfab865dcf924155cc81b763c919a53 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698