Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1494993002: Make the audio codecs' GN targets self-sufficient (Closed)

Created:
5 years ago by hlundin-webrtc
Modified:
5 years ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make the audio codecs' GN targets self-sufficient Also running "gn format" on the file. R=kwiberg@webrtc.org Committed: https://crrev.com/d048aa0e64cfb4a1633d379736405c060b881554 Cr-Commit-Position: refs/heads/master@{#10886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 8 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
hlundin-webrtc
PTAL
5 years ago (2015-12-03 14:08:27 UTC) #3
kwiberg-webrtc
lgtm
5 years ago (2015-12-03 14:22:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494993002/1
5 years ago (2015-12-03 14:50:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/7652)
5 years ago (2015-12-03 15:21:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494993002/1
5 years ago (2015-12-03 15:47:58 UTC) #10
hlundin-webrtc
Committed patchset #1 (id:1) manually as d048aa0e64cfb4a1633d379736405c060b881554 (presubmit successful).
5 years ago (2015-12-03 16:47:40 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-03 16:47:44 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d048aa0e64cfb4a1633d379736405c060b881554
Cr-Commit-Position: refs/heads/master@{#10886}

Powered by Google App Engine
This is Rietveld 408576698