Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1494693003: Remove the unused NullMediaEngine (and NullVoiceEngine+NullVideoEngine). (Closed)

Created:
5 years ago by the sun
Modified:
5 years ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove the unused NullMediaEngine (and NullVoiceEngine+NullVideoEngine). BUG= R=pthatcher@webrtc.org Committed: https://crrev.com/1a5cf6eab114462fb1111691293e5331ffe23e50 Cr-Commit-Position: refs/heads/master@{#10889}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -62 lines) Patch
M talk/media/base/mediaengine.h View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
the sun
5 years ago (2015-12-03 16:13:56 UTC) #2
pthatcher1
lgtm
5 years ago (2015-12-03 19:17:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494693003/1
5 years ago (2015-12-03 19:40:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years ago (2015-12-03 21:40:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494693003/1
5 years ago (2015-12-03 21:52:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years ago (2015-12-04 04:02:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494693003/1
5 years ago (2015-12-04 08:55:29 UTC) #13
the sun
Committed patchset #2 (id:20001) manually as 1a5cf6eab114462fb1111691293e5331ffe23e50 (presubmit successful).
5 years ago (2015-12-04 09:41:21 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-04 09:41:25 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1a5cf6eab114462fb1111691293e5331ffe23e50
Cr-Commit-Position: refs/heads/master@{#10889}

Powered by Google App Engine
This is Rietveld 408576698