Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1494473006:
Some further minor bitexact APM echo suppressor refactoring (#3) (Closed)
|
Created:
5 years ago by peah-webrtc Modified:
5 years ago CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1 Base URL:
https://chromium.googlesource.com/external/webrtc.git@ESUP_refactoring2_CL Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionSome further minor bitexact APM echo suppressor refactoring
-Moved memsets to where their variables are used.
-Removed redundant.
-Changed a pointer scalar to be accessed in pointer notation rather than
in array notation.
The change has been tested for bitexactness.
BUG=webrtc:5201
Committed: https://crrev.com/48bf2382d98871727894c3f4f501cd34a9e1e20b
Cr-Commit-Position: refs/heads/master@{#10963}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Merge from master #
Depends on Patchset: Messages
Total messages: 19 (9 generated)
Description was changed from ========== Some further minor bitexact APM echo suppressor refactoring -Moved memsets to where their variables are used. -Removed redundant. -Changed a pointer scalar to be accessed in pointer notation rather than in array notation. BUG=webrtc:5201 ========== to ========== Some further minor bitexact APM echo suppressor refactoring -Moved memsets to where their variables are used. -Removed redundant. -Changed a pointer scalar to be accessed in pointer notation rather than in array notation. BUG=webrtc:5201 ==========
peah@webrtc.org changed reviewers: + henrik.lundin@webrtc.org, minyue@webrtc.org
Description was changed from ========== Some further minor bitexact APM echo suppressor refactoring -Moved memsets to where their variables are used. -Removed redundant. -Changed a pointer scalar to be accessed in pointer notation rather than in array notation. BUG=webrtc:5201 ========== to ========== Some further minor bitexact APM echo suppressor refactoring -Moved memsets to where their variables are used. -Removed redundant. -Changed a pointer scalar to be accessed in pointer notation rather than in array notation. The change has been tested for bitexactness. BUG=webrtc:5201 ==========
https://codereview.webrtc.org/1494473006/diff/1/webrtc/modules/audio_processi... File webrtc/modules/audio_processing/aec/aec_core.c (right): https://codereview.webrtc.org/1494473006/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/aec/aec_core.c:1015: float scale, dtmp; Is dtmp used anywhere? delete it if not
lgtm https://codereview.webrtc.org/1494473006/diff/1/webrtc/modules/audio_processi... File webrtc/modules/audio_processing/aec/aec_core.c (right): https://codereview.webrtc.org/1494473006/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/aec/aec_core.c:1015: float scale, dtmp; On 2015/12/04 09:54:48, minyue-webrtc wrote: > Is dtmp used anywhere? delete it if not It looks like it is still used, but it can be made local to the scope where it is used.
https://codereview.webrtc.org/1494473006/diff/1/webrtc/modules/audio_processi... File webrtc/modules/audio_processing/aec/aec_core.c (right): https://codereview.webrtc.org/1494473006/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/aec/aec_core.c:1015: float scale, dtmp; On 2015/12/04 09:54:48, minyue-webrtc wrote: > Is dtmp used anywhere? delete it if not It is used. But is removed in one of the following CLs that makes it redundant. https://codereview.webrtc.org/1494473006/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/aec/aec_core.c:1015: float scale, dtmp; On 2015/12/04 10:49:08, hlundin-webrtc wrote: > On 2015/12/04 09:54:48, minyue-webrtc wrote: > > Is dtmp used anywhere? delete it if not > > It looks like it is still used, but it can be made local to the scope where it > is used. True, but it will be removed later when that part is rewritten.
lgtm
The CQ bit was checked by peah@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from henrik.lundin@webrtc.org, minyue@webrtc.org Link to the patchset: https://codereview.webrtc.org/1494473006/#ps20001 (title: "Merge from master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494473006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494473006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494473006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494473006/20001
Message was sent while issue was closed.
Description was changed from ========== Some further minor bitexact APM echo suppressor refactoring -Moved memsets to where their variables are used. -Removed redundant. -Changed a pointer scalar to be accessed in pointer notation rather than in array notation. The change has been tested for bitexactness. BUG=webrtc:5201 ========== to ========== Some further minor bitexact APM echo suppressor refactoring -Moved memsets to where their variables are used. -Removed redundant. -Changed a pointer scalar to be accessed in pointer notation rather than in array notation. The change has been tested for bitexactness. BUG=webrtc:5201 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Some further minor bitexact APM echo suppressor refactoring -Moved memsets to where their variables are used. -Removed redundant. -Changed a pointer scalar to be accessed in pointer notation rather than in array notation. The change has been tested for bitexactness. BUG=webrtc:5201 ========== to ========== Some further minor bitexact APM echo suppressor refactoring -Moved memsets to where their variables are used. -Removed redundant. -Changed a pointer scalar to be accessed in pointer notation rather than in array notation. The change has been tested for bitexactness. BUG=webrtc:5201 Committed: https://crrev.com/48bf2382d98871727894c3f4f501cd34a9e1e20b Cr-Commit-Position: refs/heads/master@{#10963} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/48bf2382d98871727894c3f4f501cd34a9e1e20b Cr-Commit-Position: refs/heads/master@{#10963} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
