webrtc/base/rtccertificate.h - Issue 1494103003: RTCCertificate::Expires() and ::HasExpired() implemented

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/rtccertificate.h

Issue 1494103003: RTCCertificate::Expires() and ::HasExpired() implemented (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed nits Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/base/rtccertificate.h

diff --git a/webrtc/base/rtccertificate.h b/webrtc/base/rtccertificate.h

index d238938ae185786b55a43c72eca05f81b627ec79..600739bc86a9211172337e3b88d189f95835b839 100644

--- a/webrtc/base/rtccertificate.h

+++ b/webrtc/base/rtccertificate.h

@@ -27,8 +27,11 @@ class RTCCertificate : public RefCountInterface {

// Takes ownership of |identity|.

static scoped_refptr<RTCCertificate> Create(scoped_ptr<SSLIdentity> identity);

- uint64_t expires_timestamp_ns() const;

- bool HasExpired() const;

+ // Returns the expiration time in ms relative to epoch, 1970-01-01T00:00:00Z.

+ uint64_t Expires() const;

+ // Checks if the certificate has expired, where |now| is expressed in ms

+ // relative to epoch, 1970-01-01T00:00:00Z.

+ bool HasExpired(uint64_t now) const;

const SSLCertificate& ssl_certificate() const;

// TODO(hbos): If possible, remove once RTCCertificate and its

« no previous file with comments | « webrtc/base/fakesslidentity.h ('k') | webrtc/base/rtccertificate.cc » ('j') | no next file with comments »