RTCCertificate::Expires() and ::HasExpired() implemented

webrtc/base/rtccertificate.h

 /*
  *  Copyright 2015 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_BASE_RTCCERTIFICATE_H_
 #define WEBRTC_BASE_RTCCERTIFICATE_H_
 
 #include "webrtc/base/basictypes.h"
 #include "webrtc/base/refcount.h"
 #include "webrtc/base/scoped_ptr.h"
 #include "webrtc/base/scoped_ref_ptr.h"
 #include "webrtc/base/sslidentity.h"
 
 namespace rtc {
 
 // A thin abstraction layer between "lower level crypto stuff" like
 // SSLCertificate and WebRTC usage. Takes ownership of some lower level objects,
 // reference counting protects these from premature destruction.
 class RTCCertificate : public RefCountInterface {
  public:
   // Takes ownership of |identity|.
   static scoped_refptr<RTCCertificate> Create(scoped_ptr<SSLIdentity> identity);
 
-  uint64_t expires_timestamp_ns() const;
+  // Returns the expiration time in ms relative to epoch, 1970-01-01T00:00:00Z.
+  uint64_t Expires() const;
   bool HasExpired() const;

[hta-webrtc, 2015/12/03 13:49:07]

What's the argument for using CamelCase for these functions and
lower_case_dashes for all the others?

[hbos, 2015/12/03 16:03:48]

All functions should be UpperCamel except tiny and "cheap" ones like getters,
https://google.github.io/styleguide/cppguide.html#Function_Names.

Getting the Expires() time involves lower level crypto stuff and as it happens
does some parsing so I'm not making them lower_snake like identity() and
ssl_certificate().

   const SSLCertificate& ssl_certificate() const;
 
   // TODO(hbos): If possible, remove once RTCCertificate and its
   // ssl_certificate() is used in all relevant places. Should not pass around
   // raw SSLIdentity* for the sake of accessing SSLIdentity::certificate().
   // However, some places might need SSLIdentity* for its public/private key...
   SSLIdentity* identity() const { return identity_.get(); }
 
  protected:
   explicit RTCCertificate(SSLIdentity* identity);
   ~RTCCertificate() override;
 
  private:
   // The SSLIdentity is the owner of the SSLCertificate. To protect our
   // ssl_certificate() we take ownership of |identity_|.
   scoped_ptr<SSLIdentity> identity_;
 };
 
 }  // namespace rtc
 
 #endif  // WEBRTC_BASE_RTCCERTIFICATE_H_