Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1493863002:
Add logs when stun or turn host lookup is completed. (Closed)
|
Created:
5 years ago by honghaiz3 Modified:
5 years ago Reviewers:
pthatcher1 CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd logs when stun or turn host lookup is completed.
This will help investigate issues caused by DNS lookup.
BUG=
R=pthatcher@webrtc.org
Committed: https://crrev.com/0f490a5b8609c1f10dba37d7a7b0b2fc055543eb
Cr-Commit-Position: refs/heads/master@{#10919}
Patch Set 1 : #
Total comments: 2
Patch Set 2 : #Patch Set 3 : Merge #
Messages
Total messages: 24 (14 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Add logs when stun or turn host lookup results come back. This will help debugging. BUG= ========== to ========== Add logs when stun or turn host lookup is completed. This will help debugging. BUG= ==========
Patchset #1 (id:20001) has been deleted
Description was changed from ========== Add logs when stun or turn host lookup is completed. This will help debugging. BUG= ========== to ========== Add logs when stun or turn host lookup is completed. This will help investigate issues caused by DNS lookup. BUG= ==========
honghaiz@webrtc.org changed reviewers: + pthatcher@webrtc.org
PTAL
https://codereview.webrtc.org/1493863002/diff/40001/webrtc/p2p/base/stunport.cc File webrtc/p2p/base/stunport.cc (right): https://codereview.webrtc.org/1493863002/diff/40001/webrtc/p2p/base/stunport.... webrtc/p2p/base/stunport.cc:375: LOG_J(LS_INFO, this) << "STUN host lookup result " << error; I think that what we really want is a log just *before* we do the lookup. Otherwise, we wouldn't see anything in the logs for ones that take a really long time. And in that case, we probably only want to log failures, not successes.
Patchset #2 (id:60001) has been deleted
https://codereview.webrtc.org/1493863002/diff/40001/webrtc/p2p/base/stunport.cc File webrtc/p2p/base/stunport.cc (right): https://codereview.webrtc.org/1493863002/diff/40001/webrtc/p2p/base/stunport.... webrtc/p2p/base/stunport.cc:375: LOG_J(LS_INFO, this) << "STUN host lookup result " << error; On 2015/12/02 19:56:32, pthatcher1 wrote: > I think that what we really want is a log just *before* we do the lookup. > Otherwise, we wouldn't see anything in the logs for ones that take a really long > time. > > And in that case, we probably only want to log failures, not successes. Done.
lgtm
The CQ bit was checked by honghaiz@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493863002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493863002/80001
The CQ bit was unchecked by honghaiz@webrtc.org
The CQ bit was checked by honghaiz@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org Link to the patchset: https://codereview.webrtc.org/1493863002/#ps100001 (title: "Merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493863002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493863002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_x64_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_rel/builds/5680)
The CQ bit was checked by honghaiz@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493863002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493863002/100001
Description was changed from ========== Add logs when stun or turn host lookup is completed. This will help investigate issues caused by DNS lookup. BUG= ========== to ========== Add logs when stun or turn host lookup is completed. This will help investigate issues caused by DNS lookup. BUG= R=pthatcher@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/0f490a5b8609c1f10dba37d7a... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:100001) manually as 0f490a5b8609c1f10dba37d7a7b0b2fc055543eb (presubmit successful).
Message was sent while issue was closed.
Description was changed from ========== Add logs when stun or turn host lookup is completed. This will help investigate issues caused by DNS lookup. BUG= R=pthatcher@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/0f490a5b8609c1f10dba37d7a... ========== to ========== Add logs when stun or turn host lookup is completed. This will help investigate issues caused by DNS lookup. BUG= R=pthatcher@webrtc.org Committed: https://crrev.com/0f490a5b8609c1f10dba37d7a7b0b2fc055543eb Cr-Commit-Position: refs/heads/master@{#10919} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/0f490a5b8609c1f10dba37d7a7b0b2fc055543eb Cr-Commit-Position: refs/heads/master@{#10919} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
