Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: webrtc/voice_engine/voe_base_impl.h

Issue 1493663002: Removing some unnecessary string manipulation code from VoEBase::GetVersion(). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: implicit Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 const int voe_channels[], int number_of_voe_channels, 127 const int voe_channels[], int number_of_voe_channels,
128 const void* audio_data, uint32_t sample_rate, uint8_t number_of_channels, 128 const void* audio_data, uint32_t sample_rate, uint8_t number_of_channels,
129 size_t number_of_frames, uint32_t audio_delay_milliseconds, 129 size_t number_of_frames, uint32_t audio_delay_milliseconds,
130 int32_t clock_drift, uint32_t volume, bool key_pressed); 130 int32_t clock_drift, uint32_t volume, bool key_pressed);
131 131
132 void GetPlayoutData(int sample_rate, int number_of_channels, 132 void GetPlayoutData(int sample_rate, int number_of_channels,
133 size_t number_of_frames, bool feed_data_to_apm, 133 size_t number_of_frames, bool feed_data_to_apm,
134 void* audio_data, int64_t* elapsed_time_ms, 134 void* audio_data, int64_t* elapsed_time_ms,
135 int64_t* ntp_time_ms); 135 int64_t* ntp_time_ms);
136 136
137 int32_t AddVoEVersion(char* str) const;
138
139 // Initialize channel by setting Engine Information then initializing 137 // Initialize channel by setting Engine Information then initializing
140 // channel. 138 // channel.
141 int InitializeChannel(voe::ChannelOwner* channel_owner); 139 int InitializeChannel(voe::ChannelOwner* channel_owner);
142 #ifdef WEBRTC_EXTERNAL_TRANSPORT
143 int32_t AddExternalTransportBuild(char* str) const;
144 #endif
145 VoiceEngineObserver* voiceEngineObserverPtr_; 140 VoiceEngineObserver* voiceEngineObserverPtr_;
146 CriticalSectionWrapper& callbackCritSect_; 141 CriticalSectionWrapper& callbackCritSect_;
147 142
148 AudioFrame audioFrame_; 143 AudioFrame audioFrame_;
149 voe::SharedData* shared_; 144 voe::SharedData* shared_;
150 }; 145 };
151 146
152 } // namespace webrtc 147 } // namespace webrtc
153 148
154 #endif // WEBRTC_VOICE_ENGINE_VOE_BASE_IMPL_H 149 #endif // WEBRTC_VOICE_ENGINE_VOE_BASE_IMPL_H
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698