Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: webrtc/voice_engine/include/voe_base.h

Issue 1493663002: Removing some unnecessary string manipulation code from VoEBase::GetVersion(). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: implicit Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 bool addFileCounter = false); 80 bool addFileCounter = false);
81 81
82 // Installs the TraceCallback implementation to ensure that the user 82 // Installs the TraceCallback implementation to ensure that the user
83 // receives callbacks for generated trace messages. 83 // receives callbacks for generated trace messages.
84 static int SetTraceCallback(TraceCallback* callback); 84 static int SetTraceCallback(TraceCallback* callback);
85 85
86 #if !defined(WEBRTC_CHROMIUM_BUILD) 86 #if !defined(WEBRTC_CHROMIUM_BUILD)
87 static int SetAndroidObjects(void* javaVM, void* context); 87 static int SetAndroidObjects(void* javaVM, void* context);
88 #endif 88 #endif
89 89
90 static std::string GetVersionString();
91
90 protected: 92 protected:
91 VoiceEngine() {} 93 VoiceEngine() {}
92 ~VoiceEngine() {} 94 ~VoiceEngine() {}
93 }; 95 };
94 96
95 // VoEBase 97 // VoEBase
96 class WEBRTC_DLLEXPORT VoEBase { 98 class WEBRTC_DLLEXPORT VoEBase {
97 public: 99 public:
98 // Factory for the VoEBase sub-API. Increases an internal reference 100 // Factory for the VoEBase sub-API. Increases an internal reference
99 // counter if successful. Returns NULL if the API is not supported or if 101 // counter if successful. Returns NULL if the API is not supported or if
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 virtual int AssociateSendChannel(int channel, int accociate_send_channel) = 0; 186 virtual int AssociateSendChannel(int channel, int accociate_send_channel) = 0;
185 187
186 protected: 188 protected:
187 VoEBase() {} 189 VoEBase() {}
188 virtual ~VoEBase() {} 190 virtual ~VoEBase() {}
189 }; 191 };
190 192
191 } // namespace webrtc 193 } // namespace webrtc
192 194
193 #endif // WEBRTC_VOICE_ENGINE_VOE_BASE_H 195 #endif // WEBRTC_VOICE_ENGINE_VOE_BASE_H
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698