webrtc/video_engine/vie_channel.cc - Issue 1493403003: modules/rtp_rtcp/include folder cleared of lint warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video_engine/vie_channel.cc

Issue 1493403003: modules/rtp_rtcp/include folder cleared of lint warnings (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: webrtc do not use newly depricated functions itself. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc ('K') | « webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc ('k') | webrtc/voice_engine/channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/video_engine/vie_channel.cc

diff --git a/webrtc/video_engine/vie_channel.cc b/webrtc/video_engine/vie_channel.cc

index 681f72cc06bde2f4d5d2f487f76d2d96a0a30d4f..7374cd1e582fac6cc88dd35e8ea12f80de372484 100644

--- a/webrtc/video_engine/vie_channel.cc

+++ b/webrtc/video_engine/vie_channel.cc

@@ -263,8 +263,8 @@ void ViEChannel::UpdateHistograms() {

bool fec_enabled = false;

uint8_t pltype_red;

uint8_t pltype_fec;

- rtp_rtcp_modules_[0]->GenericFECStatus(fec_enabled, pltype_red,

- pltype_fec);

+ rtp_rtcp_modules_[0]->GenericFECStatus(&fec_enabled, &pltype_red,

+ &pltype_fec);

if (fec_enabled) {

RTC_HISTOGRAM_COUNTS_10000("WebRTC.Video.FecBitrateSentInKbps",

static_cast<int>(rtp_rtx.fec.TotalBytes() *

@@ -531,7 +531,7 @@ bool ViEChannel::IsSendingFecEnabled() {

uint8_t pltype_fec = 0;

for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) {

- rtp_rtcp->GenericFECStatus(fec_enabled, pltype_red, pltype_fec);

+ rtp_rtcp->GenericFECStatus(&fec_enabled, &pltype_red, &pltype_fec);

if (fec_enabled)

return true;

}