Index: webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc |
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc |
index e20c94e7fc8846cf1a7d66e00aff5912a747f807..271d3a57c0be5566b46913eecee793390250300c 100644 |
--- a/webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc |
+++ b/webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc |
@@ -75,9 +75,9 @@ TEST_F(RtpPayloadRegistryTest, RegistersAndRemembersPayloadsUntilDeregistered) { |
EXPECT_TRUE(new_payload_created) << "A new payload WAS created."; |
- RtpUtility::Payload* retrieved_payload = NULL; |
- EXPECT_TRUE(rtp_payload_registry_->PayloadTypeToPayload(payload_type, |
- retrieved_payload)); |
+ RtpUtility::Payload* retrieved_payload = |
+ rtp_payload_registry_->PayloadTypeToPayload(payload_type); |
+ EXPECT_TRUE(retrieved_payload); |
// We should get back the exact pointer to the payload returned by the |
// payload strategy. |
@@ -85,8 +85,7 @@ TEST_F(RtpPayloadRegistryTest, RegistersAndRemembersPayloadsUntilDeregistered) { |
// Now forget about it and verify it's gone. |
EXPECT_EQ(0, rtp_payload_registry_->DeRegisterReceivePayload(payload_type)); |
- EXPECT_FALSE(rtp_payload_registry_->PayloadTypeToPayload( |
- payload_type, retrieved_payload)); |
+ EXPECT_FALSE(rtp_payload_registry_->PayloadTypeToPayload(payload_type)); |
} |
TEST_F(RtpPayloadRegistryTest, AudioRedWorkProperly) { |
@@ -107,10 +106,9 @@ TEST_F(RtpPayloadRegistryTest, AudioRedWorkProperly) { |
EXPECT_EQ(kRedPayloadType, rtp_payload_registry_->red_payload_type()); |
- RtpUtility::Payload* retrieved_payload = NULL; |
- EXPECT_TRUE(rtp_payload_registry_->PayloadTypeToPayload(kRedPayloadType, |
- retrieved_payload)); |
- ASSERT_TRUE(retrieved_payload); |
+ RtpUtility::Payload* retrieved_payload = |
+ rtp_payload_registry_->PayloadTypeToPayload(kRedPayloadType); |
+ EXPECT_TRUE(retrieved_payload); |
EXPECT_TRUE(retrieved_payload->audio); |
EXPECT_STRCASEEQ("red", retrieved_payload->name); |
@@ -142,12 +140,13 @@ TEST_F(RtpPayloadRegistryTest, |
"With a different payload type is fine though."; |
// Ensure both payloads are preserved. |
- RtpUtility::Payload* retrieved_payload = NULL; |
- EXPECT_TRUE(rtp_payload_registry_->PayloadTypeToPayload(payload_type, |
- retrieved_payload)); |
+ const RtpUtility::Payload* retrieved_payload = |
+ rtp_payload_registry_->PayloadTypeToPayload(payload_type); |
+ EXPECT_TRUE(retrieved_payload); |
EXPECT_EQ(first_payload_on_heap, retrieved_payload); |
- EXPECT_TRUE(rtp_payload_registry_->PayloadTypeToPayload(payload_type - 1, |
- retrieved_payload)); |
+ retrieved_payload = |
+ rtp_payload_registry_->PayloadTypeToPayload(payload_type - 1); |
+ EXPECT_TRUE(retrieved_payload); |
EXPECT_EQ(second_payload_on_heap, retrieved_payload); |
// Ok, update the rate for one of the codecs. If either the incoming rate or |
@@ -181,13 +180,13 @@ TEST_F(RtpPayloadRegistryTest, |
kTypicalPayloadName, payload_type - 1, kTypicalFrequency, |
kTypicalChannels, kTypicalRate, &ignored)); |
- RtpUtility::Payload* retrieved_payload = NULL; |
- EXPECT_FALSE(rtp_payload_registry_->PayloadTypeToPayload( |
- payload_type, retrieved_payload)) << "The first payload should be " |
- "deregistered because the only thing that differs is payload type."; |
- EXPECT_TRUE(rtp_payload_registry_->PayloadTypeToPayload( |
- payload_type - 1, retrieved_payload)) << |
- "The second payload should still be registered though."; |
+ EXPECT_FALSE(rtp_payload_registry_->PayloadTypeToPayload(payload_type)) |
+ << "The first payload should be " |
+ "deregistered because the only thing that differs is payload type."; |
+ const RtpUtility::Payload* retrieved_payload = |
+ rtp_payload_registry_->PayloadTypeToPayload(payload_type - 1); |
+ EXPECT_TRUE(retrieved_payload) |
+ << "The second payload should still be registered though."; |
// Now ensure non-compatible codecs aren't removed. |
ON_CALL(*mock_payload_strategy_, PayloadIsCompatible(_, _, _, _)) |
@@ -197,12 +196,10 @@ TEST_F(RtpPayloadRegistryTest, |
kTypicalPayloadName, payload_type + 1, kTypicalFrequency, |
kTypicalChannels, kTypicalRate, &ignored)); |
- EXPECT_TRUE(rtp_payload_registry_->PayloadTypeToPayload( |
- payload_type - 1, retrieved_payload)) << |
- "Not compatible; both payloads should be kept."; |
- EXPECT_TRUE(rtp_payload_registry_->PayloadTypeToPayload( |
- payload_type + 1, retrieved_payload)) << |
- "Not compatible; both payloads should be kept."; |
+ EXPECT_TRUE(rtp_payload_registry_->PayloadTypeToPayload(payload_type - 1)) |
+ << "Not compatible; both payloads should be kept."; |
+ EXPECT_TRUE(rtp_payload_registry_->PayloadTypeToPayload(payload_type + 1)) |
+ << "Not compatible; both payloads should be kept."; |
} |
TEST_F(RtpPayloadRegistryTest, |