Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Side by Side Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Issue 1493403003: modules/rtp_rtcp/include folder cleared of lint warnings (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: webrtc do not use newly depricated functions itself. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_ 11 #ifndef WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_
12 #define WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_ 12 #define WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_
13 13
14 #include <set> 14 #include <set>
15 #include <vector> 15 #include <vector>
16 #include <utility>
mflodman 2015/12/09 09:19:13 Alphabetic order.
danilchap 2015/12/09 11:23:36 Done.
16 17
17 #include "webrtc/modules/include/module.h" 18 #include "webrtc/modules/include/module.h"
18 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h" 19 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
19 20
20 namespace webrtc { 21 namespace webrtc {
21 // Forward declarations. 22 // Forward declarations.
22 class ReceiveStatistics; 23 class ReceiveStatistics;
23 class RemoteBitrateEstimator; 24 class RemoteBitrateEstimator;
24 class RtpReceiver; 25 class RtpReceiver;
25 class Transport; 26 class Transport;
(...skipping 547 matching lines...) Expand 10 before | Expand all | Expand 10 after
573 * 574 *
574 * return -1 on failure else 0 575 * return -1 on failure else 0
575 */ 576 */
576 virtual int32_t SetSendREDPayloadType(int8_t payloadType) = 0; 577 virtual int32_t SetSendREDPayloadType(int8_t payloadType) = 0;
577 578
578 /* 579 /*
579 * Get payload type for Redundant Audio Data RFC 2198 580 * Get payload type for Redundant Audio Data RFC 2198
580 * 581 *
581 * return -1 on failure else 0 582 * return -1 on failure else 0
582 */ 583 */
583 virtual int32_t SendREDPayloadType( 584 // NOLINTNEXTLINE
584 int8_t& payloadType) const = 0; 585 int32_t SendREDPayloadType(int8_t& payloadType) const { // Depricated.
585 586 return SendREDPayloadType(&payloadType);
587 }
588 virtual int32_t SendREDPayloadType(int8_t* payload_type) const = 0;
586 /* 589 /*
587 * Store the audio level in dBov for header-extension-for-audio-level- 590 * Store the audio level in dBov for header-extension-for-audio-level-
588 * indication. 591 * indication.
589 * This API shall be called before transmision of an RTP packet to ensure 592 * This API shall be called before transmision of an RTP packet to ensure
590 * that the |level| part of the extended RTP header is updated. 593 * that the |level| part of the extended RTP header is updated.
591 * 594 *
592 * return -1 on failure else 0. 595 * return -1 on failure else 0.
593 */ 596 */
594 virtual int32_t SetAudioLevel(uint8_t level_dBov) = 0; 597 virtual int32_t SetAudioLevel(uint8_t level_dBov) = 0;
595 598
(...skipping 11 matching lines...) Expand all
607 /* 610 /*
608 * Turn on/off generic FEC 611 * Turn on/off generic FEC
609 */ 612 */
610 virtual void SetGenericFECStatus(bool enable, 613 virtual void SetGenericFECStatus(bool enable,
611 uint8_t payload_type_red, 614 uint8_t payload_type_red,
612 uint8_t payload_type_fec) = 0; 615 uint8_t payload_type_fec) = 0;
613 616
614 /* 617 /*
615 * Get generic FEC setting 618 * Get generic FEC setting
616 */ 619 */
617 virtual void GenericFECStatus(bool& enable, 620 // Depricated.
618 uint8_t& payloadTypeRED, 621 void GenericFECStatus(bool& enable, // NOLINT
619 uint8_t& payloadTypeFEC) = 0; 622 uint8_t& payloadTypeRED, // NOLINT
620 623 uint8_t& payloadTypeFEC) { // NOLINT
624 GenericFECStatus(&enable, &payloadTypeRED, &payloadTypeFEC);
625 }
626 virtual void GenericFECStatus(bool* enable,
627 uint8_t* payload_type_red,
628 uint8_t* payload_type_fec) = 0;
621 629
622 virtual int32_t SetFecParameters( 630 virtual int32_t SetFecParameters(
623 const FecProtectionParams* delta_params, 631 const FecProtectionParams* delta_params,
624 const FecProtectionParams* key_params) = 0; 632 const FecProtectionParams* key_params) = 0;
625 633
626 /* 634 /*
627 * Set method for requestion a new key frame 635 * Set method for requestion a new key frame
628 * 636 *
629 * return -1 on failure else 0 637 * return -1 on failure else 0
630 */ 638 */
631 virtual int32_t SetKeyFrameRequestMethod(KeyFrameRequestMethod method) = 0; 639 virtual int32_t SetKeyFrameRequestMethod(KeyFrameRequestMethod method) = 0;
632 640
633 /* 641 /*
634 * send a request for a keyframe 642 * send a request for a keyframe
635 * 643 *
636 * return -1 on failure else 0 644 * return -1 on failure else 0
637 */ 645 */
638 virtual int32_t RequestKeyFrame() = 0; 646 virtual int32_t RequestKeyFrame() = 0;
639 }; 647 };
640 } // namespace webrtc 648 } // namespace webrtc
641 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_ 649 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698