Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1493003002: Fix Mac ObjC PeerConnection API compilation. (Closed)

Created:
5 years ago by tkchin_webrtc
Modified:
5 years ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix Mac ObjC PeerConnection API compilation. BUG=webrtc:5287, webrtc:5216 Committed: https://crrev.com/7635684130cc3a071d245b607fddec059002e7fa Cr-Commit-Position: refs/heads/master@{#10876}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M talk/build/merge_ios_libs.gyp View 1 chunk +1 line, -1 line 0 comments Download
M talk/libjingle.gyp View 1 chunk +1 line, -1 line 0 comments Download
M talk/libjingle_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/webrtc_examples.gyp View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
tkchin_webrtc
5 years ago (2015-12-02 20:24:55 UTC) #3
tkchin_webrtc
5 years ago (2015-12-02 20:24:59 UTC) #4
kjellander_webrtc
lgtm PS. I changed your BUG= entries to be BUG=webrtc:5287, webrtc:5216 to make the links ...
5 years ago (2015-12-02 21:22:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493003002/1
5 years ago (2015-12-02 21:50:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/11061)
5 years ago (2015-12-02 21:59:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493003002/1
5 years ago (2015-12-02 23:13:02 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 00:42:22 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-03 00:42:50 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7635684130cc3a071d245b607fddec059002e7fa
Cr-Commit-Position: refs/heads/master@{#10876}

Powered by Google App Engine
This is Rietveld 408576698