Add tests for vp9 (non-flexible mode) using different spatial and temporal configurations.

Add tests for vp9 (non-flexible mode) using different spatial and temporal configurations.

Specify kf_min_dist to get correct key frame interval in svc mode.

Also set QP-max/min per temporal and spatial layer (was previously only allowed to be set per spatial layer).

BUG=chromium:500602
R=stefan@webrtc.org

Committed: https://crrev.com/ff24c04c7319478c71608974352e0d63e22f8589
Cr-Commit-Position: refs/heads/master@{#10890}

[åsapersson, 2015-12-02 13:39:59]

Description was changed from

==========
Add tests for vp9 (non-flexible mode) using different spatial and temporal
configurations.

Specify kf_min_dist to get correct key frame interval in svc mode.

BUG=chromium:500602
==========

to

==========
Reland: Add tests for vp9 (non-flexible mode) using different spatial and
temporal configurations.

Specify kf_min_dist to get correct key frame interval in svc mode.

BUG=chromium:500602
==========

[åsapersson, 2015-12-03 07:40:57]

Patchset #2 (id:10001) has been deleted

[åsapersson, 2015-12-03 07:42:16]

Patchset #1 (id:1) has been deleted

[åsapersson, 2015-12-03 07:57:53]

Patchset #2 (id:40001) has been deleted

[åsapersson, 2015-12-03 07:59:46]

Description was changed from

==========
Reland: Add tests for vp9 (non-flexible mode) using different spatial and
temporal configurations.

Specify kf_min_dist to get correct key frame interval in svc mode.

BUG=chromium:500602
==========

to

==========
Reland: Add tests for vp9 (non-flexible mode) using different spatial and
temporal configurations.

Specify kf_min_dist to get correct key frame interval in svc mode.

Also set QP-max/min per temporal and spatial (was previously only allowed to be
set per spatial layer).

BUG=chromium:500602
==========

[åsapersson, 2015-12-03 08:02:41]

Description was changed from

==========
Reland: Add tests for vp9 (non-flexible mode) using different spatial and
temporal configurations.

Specify kf_min_dist to get correct key frame interval in svc mode.

Also set QP-max/min per temporal and spatial (was previously only allowed to be
set per spatial layer).

BUG=chromium:500602
==========

to

==========
Reland: Add tests for vp9 (non-flexible mode) using different spatial and
temporal configurations.

Specify kf_min_dist to get correct key frame interval in svc mode.

Also set QP-max/min per temporal and spatial layer (was previously only allowed
to be set per spatial layer).

BUG=chromium:500602
==========

[åsapersson, 2015-12-03 08:02:41]

asapersson@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2015-12-03 08:44:44]

https://codereview.webrtc.org/1492633005/diff/60001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right):

https://codereview.webrtc.org/1492633005/diff/60001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:385: int tot_num_layers =
num_spatial_layers_ * num_temporal_layers_;
I don't fully understand this. Has the max/min_quantizers[] changed to be an
array of all layer quantizers including temporal, or did we just misconfigure it
before?

Does scaling_factor_num/den have the same range? In that case, is it really
correct to only set the first num_spatial_layers_ elements?

[åsapersson, 2015-12-03 09:16:25]

https://codereview.webrtc.org/1492633005/diff/60001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right):

https://codereview.webrtc.org/1492633005/diff/60001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:385: int tot_num_layers =
num_spatial_layers_ * num_temporal_layers_;
On 2015/12/03 08:44:44, stefan-webrtc (holmer) wrote:
> I don't fully understand this. Has the max/min_quantizers[] changed to be an
> array of all layer quantizers including temporal, or did we just misconfigure
it
> before?
> 
> Does scaling_factor_num/den have the same range? In that case, is it really
> correct to only set the first num_spatial_layers_ elements?

The configuration has changed in the latest version. Now QP-max/min can be set
per temporal and spatial layer (was previously only allowed
to be set per spatial layer). Added a comment.

[stefan-webrtc, 2015-12-03 15:57:41]

lgtm

[åsapersson, 2015-12-04 07:54:13]

Description was changed from

==========
Reland: Add tests for vp9 (non-flexible mode) using different spatial and
temporal configurations.

Specify kf_min_dist to get correct key frame interval in svc mode.

Also set QP-max/min per temporal and spatial layer (was previously only allowed
to be set per spatial layer).

BUG=chromium:500602
==========

to

==========
Add tests for vp9 (non-flexible mode) using different spatial and temporal
configurations.

Specify kf_min_dist to get correct key frame interval in svc mode.

Also set QP-max/min per temporal and spatial layer (was previously only allowed
to be set per spatial layer).

BUG=chromium:500602
==========

[åsapersson, 2015-12-04 07:55:50]

The CQ bit was checked by asapersson@webrtc.org

[commit-bot: I haz the power, 2015-12-04 07:56:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1492633005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1492633005/100001

[commit-bot: I haz the power, 2015-12-04 09:56:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 09:56:18]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[åsapersson, 2015-12-04 09:58:28]

Description was changed from

==========
Add tests for vp9 (non-flexible mode) using different spatial and temporal
configurations.

Specify kf_min_dist to get correct key frame interval in svc mode.

Also set QP-max/min per temporal and spatial layer (was previously only allowed
to be set per spatial layer).

BUG=chromium:500602
==========

to

==========
Add tests for vp9 (non-flexible mode) using different spatial and temporal
configurations.

Specify kf_min_dist to get correct key frame interval in svc mode.

Also set QP-max/min per temporal and spatial layer (was previously only allowed
to be set per spatial layer).

BUG=chromium:500602
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/ff24c04c7319478c716089743...
==========

[åsapersson, 2015-12-04 09:58:29]

Committed patchset #5 (id:120001) manually as
ff24c04c7319478c71608974352e0d63e22f8589 (presubmit successful).

[commit-bot: I haz the power, 2015-12-04 09:58:32]

Description was changed from

==========
Add tests for vp9 (non-flexible mode) using different spatial and temporal
configurations.

Specify kf_min_dist to get correct key frame interval in svc mode.

Also set QP-max/min per temporal and spatial layer (was previously only allowed
to be set per spatial layer).

BUG=chromium:500602
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/ff24c04c7319478c716089743...
==========

to

==========
Add tests for vp9 (non-flexible mode) using different spatial and temporal
configurations.

Specify kf_min_dist to get correct key frame interval in svc mode.

Also set QP-max/min per temporal and spatial layer (was previously only allowed
to be set per spatial layer).

BUG=chromium:500602
R=stefan@webrtc.org

Committed: https://crrev.com/ff24c04c7319478c71608974352e0d63e22f8589
Cr-Commit-Position: refs/heads/master@{#10890}
==========

[commit-bot: I haz the power, 2015-12-04 09:58:32]

Patchset 5 (id:??) landed as
https://crrev.com/ff24c04c7319478c71608974352e0d63e22f8589
Cr-Commit-Position: refs/heads/master@{#10890}