Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Unified Diff: webrtc/modules/video_processing/util/denoiser_filter_c.cc

Issue 1492053003: Add unit test for stand-alone denoiser and fixed some bugs. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix asan test failure. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_processing/util/denoiser_filter_c.cc
diff --git a/webrtc/modules/video_processing/util/denoiser_filter_c.cc b/webrtc/modules/video_processing/util/denoiser_filter_c.cc
index e32bf838895e430037d51e64bbfb749b577cf80c..0ea9926508bc1c1869dbbd0859524b2226e1bd08 100644
--- a/webrtc/modules/video_processing/util/denoiser_filter_c.cc
+++ b/webrtc/modules/video_processing/util/denoiser_filter_c.cc
@@ -56,7 +56,7 @@ uint32_t DenoiserFilterC::Variance16x8(const uint8_t* a,
a += a_stride;
b += b_stride;
}
- return *sse - ((static_cast<int64_t>(sum) * sum) >> 8);
+ return *sse - ((static_cast<int64_t>(sum) * sum) >> 7);
stefan-webrtc 2015/12/10 08:53:25 Was this a bug? Not entirely clear to me why it sh
jackychen 2015/12/11 19:57:57 Yes. Previously, we used variance of 16x16, but we
stefan-webrtc 2015/12/15 21:00:30 Great!
}
DenoiserDecision DenoiserFilterC::MbDenoise(uint8_t* mc_running_avg_y,

Powered by Google App Engine
This is Rietveld 408576698