webrtc/modules/video_processing/util/denoiser_filter_c.cc - Issue 1492053003: Add unit test for stand-alone denoiser and fixed some bugs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_processing/util/denoiser_filter_c.cc

Issue 1492053003: Add unit test for stand-alone denoiser and fixed some bugs. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/video_processing/test/denoiser_test.cc ('K') | « webrtc/modules/video_processing/util/denoiser_filter.cc ('k') | webrtc/modules/video_processing/util/denoiser_filter_sse2.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_processing/util/denoiser_filter_c.cc

diff --git a/webrtc/modules/video_processing/util/denoiser_filter_c.cc b/webrtc/modules/video_processing/util/denoiser_filter_c.cc

index e32bf838895e430037d51e64bbfb749b577cf80c..6323980e1823559ac86910522d93dbb365f1a05b 100644

--- a/webrtc/modules/video_processing/util/denoiser_filter_c.cc

+++ b/webrtc/modules/video_processing/util/denoiser_filter_c.cc

@@ -56,7 +56,7 @@ uint32_t DenoiserFilterC::Variance16x8(const uint8_t* a,

a += a_stride;

b += b_stride;

}

- return *sse - ((static_cast<int64_t>(sum) * sum) >> 8);

+ return *sse - ((static_cast<int64_t>(sum) * sum) >> 7);

}

DenoiserDecision DenoiserFilterC::MbDenoise(uint8_t* mc_running_avg_y,

@@ -72,7 +72,7 @@ DenoiserDecision DenoiserFilterC::MbDenoise(uint8_t* mc_running_avg_y,

int adj_val[3] = {3, 4, 6};

int shift_inc1 = 0;

int shift_inc2 = 1;

- int col_sum[16] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0};

+ int col_sum[16] = {0};

if (motion_magnitude <= kMotionMagnitudeThreshold) {

if (increase_denoising) {

shift_inc1 = 1;