Add unit test for stand-alone denoiser and fixed some bugs.

webrtc/modules/video_processing/video_denoiser.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 #include "webrtc/common_video/libyuv/include/scaler.h"
 #include "webrtc/common_video/libyuv/include/webrtc_libyuv.h"
 #include "webrtc/modules/video_processing/video_denoiser.h"
 
 namespace webrtc {
 
-VideoDenoiser::VideoDenoiser()
-    : width_(0), height_(0), filter_(DenoiserFilter::Create()) {}
+VideoDenoiser::VideoDenoiser(bool runtime_cpu_detection)
+    : width_(0),
+      height_(0),
+      filter_(DenoiserFilter::Create(runtime_cpu_detection)) {}
 
 void VideoDenoiser::TrailingReduction(int mb_rows,
                                       int mb_cols,
                                       const uint8_t* y_src,
                                       int stride_y,
                                       uint8_t* y_dst) {
   for (int mb_row = 1; mb_row < mb_rows - 1; ++mb_row) {
     for (int mb_col = 1; mb_col < mb_cols - 1; ++mb_col) {
       int mb_index = mb_row * mb_cols + mb_col;
       uint8_t* mb_dst = y_dst + (mb_row << 4) * stride_y + (mb_col << 4);
@@ skipping 43 matching lines @@
                                 stride_y, stride_u, stride_v);
     // Setting time parameters to the output frame.
     denoised_frame->set_timestamp(frame.timestamp());
     denoised_frame->set_render_time_ms(frame.render_time_ms());
     return;
   }
   // For 16x16 block.
   int mb_cols = width_ >> 4;
   int mb_rows = height_ >> 4;
   if (metrics_.get() == nullptr)
-    metrics_.reset(new DenoiseMetrics[mb_cols * mb_rows]);
+    metrics_.reset(new DenoiseMetrics[mb_cols * mb_rows]());

[tommi (sloooow) - chröme, 2016/01/12 12:01:21]

I'm curious about what this change does?

[jackychen_, 2016/01/13 03:07:50]

This is to initialize the array, since the msan test will check this and give a
warning, though it is not necessary to init it.
This will only do once when the denoiser starts, so not expensive.

   // Denoise on Y plane.
   uint8_t* y_dst = denoised_frame->buffer(kYPlane);
   uint8_t* u_dst = denoised_frame->buffer(kUPlane);
   uint8_t* v_dst = denoised_frame->buffer(kVPlane);
   const uint8_t* y_src = frame.buffer(kYPlane);
   const uint8_t* u_src = frame.buffer(kUPlane);
   const uint8_t* v_src = frame.buffer(kVPlane);
   // Temporary buffer to store denoising result.
   uint8_t y_tmp[16 * 16] = {0};
   for (int mb_row = 0; mb_row < mb_rows; ++mb_row) {
@@ skipping 44 matching lines @@
   // neighbors' denoising status.
   TrailingReduction(mb_rows, mb_cols, y_src, stride_y, y_dst);
 
   // Setting time parameters to the output frame.
   denoised_frame->set_timestamp(frame.timestamp());
   denoised_frame->set_render_time_ms(frame.render_time_ms());
   return;
 }
 
 }  // namespace webrtc